Android: fix dialog button colors in dark mode #15091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @webwarrior-ws! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jfversluis
added
platform/android 🤖
area-controls-dialogalert
ghost
added
the
legacy-area-controls
Redth
reviewed
May 15, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Added tests for checking brightness of AlertDialog button text to make sure that in dark mode the text is bright (background is dark) and in light mode text is dark (background is light). |
parhamsaremi
added a commit
to parhamsaremi/DG
that referenced
this pull request
May 17, 2023
Add simple styles.xml to workaround the maui styling bug in dark theme [1]. Should be removed after merging [2]. [1] dotnet/maui#15088 [2] dotnet/maui#15091
parhamsaremi
added a commit
to parhamsaremi/DG
that referenced
this pull request
May 17, 2023
Add simple styles.xml to workaround the maui styling bug in dark theme [1]. Should be removed after merging [2]. [1] dotnet/maui#15088 [2] dotnet/maui#15091
parhamsaremi
added a commit
to parhamsaremi/DG
that referenced
this pull request
May 18, 2023
Add simple styles.xml to workaround the maui styling bug in dark theme [1]. Should be removed after merging [2]. [1] dotnet/maui#15088 [2] dotnet/maui#15091
parhamsaremi
added a commit
to parhamsaremi/DG
that referenced
this pull request
May 18, 2023
Add simple styles.xml to workaround the maui styling bug in dark theme [1]. Should be removed after merging [2]. [1] dotnet/maui#15088 [2] dotnet/maui#15091
parhamsaremi
added a commit
to parhamsaremi/DG
that referenced
this pull request
May 18, 2023
Add simple styles.xml to workaround the maui styling bug in dark theme [1]. Should be removed after merging [2]. [1] dotnet/maui#15088 [2] dotnet/maui#15091
parhamsaremi
added a commit
to parhamsaremi/DG
that referenced
this pull request
May 18, 2023
Add simple styles.xml to workaround the maui styling bug in dark theme [1]. Should be removed after merging [2]. [1] dotnet/maui#15088 [2] dotnet/maui#15091
mattleibow
reviewed
May 19, 2023
| public partial class AlertDialogTests: ControlsHandlerTestBase | ||
| { | ||
|
|
||
| async Task<Color> GetDialogButtonTextColor(int nightMode) |
parhamsaremi
added a commit
to parhamsaremi/DG
that referenced
this pull request
May 22, 2023
Add simple styles.xml to workaround the maui styling bug in dark theme [1]. Should be removed after merging [2]. [1] dotnet/maui#15088 [2] dotnet/maui#15091
parhamsaremi
added a commit
to parhamsaremi/DG
that referenced
this pull request
May 22, 2023
Add simple styles.xml to workaround the maui styling bug in dark theme [1]. Should be removed after merging [2]. [1] dotnet/maui#15088 [2] dotnet/maui#15091
parhamsaremi
added a commit
to parhamsaremi/DG
that referenced
this pull request
May 22, 2023
Add simple styles.xml to workaround the maui styling bug in dark theme [1]. Should be removed after merging [2]. [1] dotnet/maui#15088 [2] dotnet/maui#15091
knocte
pushed a commit
to parhamsaremi/DG
that referenced
this pull request
May 23, 2023
Add simple styles.xml to workaround the maui styling bug in dark theme [1]. Should be removed after merging [2]. [1] dotnet/maui#15088 [2] dotnet/maui#15091
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Redth
approved these changes
Jun 28, 2023
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@webwarrior-ws can you rebase or merge this PR with main please? I'm hoping that'll fix the failing tests. I tried, but it looks like I don't have permission to update your branch. |
|
Hi @webwarrior-ws. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time. |
Fix alert dialog button colors in dark mode. Use ?attr/colorOnSurface for text color in dialogs. This ensures contrasting color for both dark and light modes.
Use AppCompat version of AlertDialog in picker. This ensures consistent styling between picker dialog and alert dialog.
Add tests for checking brightness of AlertDialog button text. Co-authored-by: webwarrior <reg@webwarrior.ws>
webwarrior-ws
force-pushed
the
fix-dialog-button-colors
branch
from
1c40bc7
to
d66a27e
Compare
Rebased on main. |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi. any idea when this will be available in a public release? I have the same issue with dialogs |
|
Still experiencing this |
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.7.8842
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix alert dialog button colors in dark mode.
Use ?attr/colorOnSurface for text color in dialogs.
This ensures contrasting color for both dark and light modes.
Use AppCompat version of AlertDialog in picker.
This ensures consistent styling between picker dialog and
alert dialog.
Fixes
Fixes #15088
Screenshots
Now dialogs with default Android theme look like this: