Workaround WinUI bug with adding/removing flyouts #14985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
legacy-area-controls
StephaneDelcroix
pushed a commit
that referenced
this pull request
Jun 19, 2023
2 tasks
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.6.8686
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Workaround an issue in
WinUIwhere you can't add/remove flyout items to a submenu.The fix was a bit more involved than I'd hoped it would be. You basically have to remove the SubMenuItem and recreate the entire thing in order to modify the menu. At least that's the only way I could get it to work.
Issues Fixed
Fixes #14984
Testing
This is all visual so we can't really use our device tests for this