Use AppendToMapping for Element and VisualElement #14948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
force-pushed
the
dev/update-mappers
branch
3 times, most recently
from
120f110
to
2dd58df
Compare
Co-authored-by: Rachel Kang <rachelkang@microsoft.com>
# Conflicts: # src/Controls/src/Core/Layout/Layout.Android.cs # src/Controls/src/Core/Layout/Layout.Mapper.cs # src/Controls/src/Core/Layout/Layout.Tizen.cs # src/Controls/src/Core/Layout/Layout.Windows.cs # src/Controls/src/Core/Layout/Layout.iOS.cs # src/Controls/src/Core/Platform/iOS/Extensions/TextExtensions.cs # src/Controls/src/Core/SearchBar/SearchBar.Mapper.cs # src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.cs
# Conflicts: # eng/pipelines/handlers.yml # src/Controls/src/Core/Element/Element.Mapper.cs # src/Controls/src/Core/HandlerImpl/Application/Application.cs # src/Controls/src/Core/HandlerImpl/Window/Window.cs # src/Controls/src/Core/VisualElement/VisualElement.Mapper.cs
samhouts
added
legacy-area-controls
# Conflicts: # eng/pipelines/common/device-tests-steps.yml
|
This is now moved to #13836 |
Eilon
added
area-controls-general
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR move more things to using the new mapper modifiers instead of the current mapper replacement. This preserves the references as well as avoids any AOT assembly ordering issues.
Part of the fix for #11662 and part of PR #13836
PENDING PRs: