Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Correctly notify ImageButton border changes #14874

Merged
merged 4 commits into from
May 11, 2023

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Doing a quick validation of another issue I realized that the changes in the BorderWidth of the ImageButton are not notified. This PR include changes to correctly notify ImageButton border changes on Android.

fix-imagebutton-border-update

@jsuarezruiz jsuarezruiz added t/bug Something isn't working t/housekeeping ♻︎ area-controls-button Button, ImageButton labels May 2, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 2, 2023
@jfversluis jfversluis merged commit 407ccd2 into main May 11, 2023
@jfversluis jfversluis deleted the housekeeping-imagebutton-borderwidth branch May 11, 2023 11:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-button Button, ImageButton fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! platform/android 🤖 t/bug Something isn't working t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants