[Windows] Allow to customize the Shell FlyoutIcon #14663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
jsuarezruiz
changed the title
PureWeen
requested changes
Jun 27, 2023
PureWeen
requested changes
Jul 5, 2023
PureWeen
requested changes
Jul 17, 2023
src/Controls/tests/DeviceTests/Elements/Shell/ShellTests.Windows.cs
Outdated
Show resolved
Hide resolved
PureWeen
requested changes
Jul 17, 2023
|
|
||
| var animatedIcon = togglePaneButton.GetFirstDescendant<AnimatedIcon>(); | ||
|
|
||
| if (animatedIcon is null) |
There was a problem hiding this comment.
I'm running this locally and this is always null for me, and the icon isn't changing.
I tested on the sandbox
<Shell
xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="Maui.Controls.Sample.SandboxShell"
xmlns:local="clr-namespace:Maui.Controls.Sample"
x:Name="shell"
FlyoutIcon="dotnet_bot.png">There was a problem hiding this comment.
Have done some tests and I think have been an error doing fallback to the original icon. Fixed here 7766d4c
Tested on the Gallery and with Device tests.
PureWeen
requested changes
Jul 21, 2023
PureWeen
approved these changes
Jul 25, 2023
samhouts
added
the
fixed-in-8.0.0-preview.7.8842
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Allow to customize the Shell FlyoutIcon on Windows.
Issues Fixed
Fixes #7577