Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ios page background #1279

Merged
merged 7 commits into from
Jun 11, 2021
Merged

Conversation

PureWeen
Copy link
Member

Description of Change

Set Page Background using BackgroundColor instead of layers

@PureWeen PureWeen changed the base branch from main to release/6.0.1xx-preview5 June 11, 2021 21:06

<layout:GridLayout x:Name="MyLayout" Margin="40" BackgroundColor="LightGreen">
<ScrollView Padding="{OnPlatform iOS='30,60,30,30', Default='30'}">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked in our sample as the xamlapp so we can test it more easily

@PureWeen PureWeen changed the title Fix ios page background [WiP] Fix ios page background Jun 11, 2021
@mattleibow mattleibow self-requested a review June 11, 2021 21:51
@PureWeen PureWeen changed the title [WiP] Fix ios page background Fix ios page background Jun 11, 2021
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now that we can keep the page layers. Still a bit sketchy, but butter.

@mattleibow mattleibow merged commit 37f0b28 into release/6.0.1xx-preview5 Jun 11, 2021
@mattleibow mattleibow deleted the fix_ios_page_background branch June 11, 2021 23:19
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-pages Page types fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants