Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Compatibility non net6 to be multi targeted #1079

Merged
merged 2 commits into from
May 25, 2021

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented May 25, 2021

Description of Change

  • While working through converting our Control Gallery to Maui Startup I realized I'd need to be able to call the compatibility AppHostBuilderExtensions (and a couple other things) from a NS2.0 compiled project. This was easy enough to do with our NET6 sln but the non-net6 sln wasn't multi targeted

  • Remove code that sets up and verifies if the code is running in designer mode. The way the designer bool was being set wasn't playing very nicely with MauiAppCompatActivity

@PureWeen PureWeen requested a review from mattleibow May 25, 2021 01:53
@PureWeen PureWeen force-pushed the multitarget_compatibility branch from 25e951b to d29925c Compare May 25, 2021 01:57
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. No more designer stuff and removing a project!

@PureWeen PureWeen merged commit b716a5f into main May 25, 2021
@PureWeen PureWeen deleted the multitarget_compatibility branch May 25, 2021 13:54
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
@Eilon Eilon removed area/toolbar legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 10, 2024
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants