Fixes SonarQube's "Null checks should not be used with 'is'" / Code Smell

[marodev]

Hello,

I am aware that there is no open issue for this kind of contribution. However, this pull request is very simple and aims to reduce the technical debt. It specifically targets the "Null checks should not be used with 'is'" rule reported by SonarQube.

Description of Change

• Fixes SonarQube's "Null checks should not be used with 'is'" / Code Smell / Minor

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

[GalaxiaGuy]

Does this actually do the same thing as before?

parentPage != null && !(parentPage is Page)

would be false when parentPage is null

parentPage is not Page

Would this still be false is parentPage is null?

[marodev]

Hi Oliver, thanks for the question.

It would still be false if parentPage is null.

A simple example:

string s = null;
if (s is not string)
{
    Console.WriteLine("It's NOT a string.");
}
else
{
    Console.WriteLine("It's a string.");
}

prints It's NOT a string. to the console.

[GalaxiaGuy]

I understand what the is not is doing, but the code you're replacing is not quite doing that. It's checking if it is not a Page and is also not null:

		object myString = "Hello";
		var result1 = (myString != null && !(myString is string));
		
		myString = null;
		var result2 = (myString is not string);	
		
		System.Console.WriteLine(result1);
		System.Console.WriteLine(result2);

result1 is false
result2 is true

[marodev]

Thanks for this! I reverted to the previous != null && !(...) pattern

[rmarinho]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).