Only register Blazor Components when using FullDI #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
approved these changes
May 17, 2021
Eilon
reviewed
May 17, 2021
Eilon
approved these changes
May 17, 2021
lytico
pushed a commit
to lytico/maui
that referenced
this pull request
May 20, 2021
* Only register Blazor Components when using FullDI * Update Startup.cs
samhouts
added
the
fixed-in-6.0.100-preview.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
AddBlazorWebViewregisters the Extension Hosting Logging Factory that can only be instantiated via the Extension Hosting DISo we need to not call
AddBlazorWebViewif we aren't using FullDI or the BlazorWebView