[build] extract .NET workloads to a temp folder #1027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Our build currently emits some confusing warnings such as:
Only the very last line is actually relevant:
This is because we are extracting the workload
.nupkg
files directlyinto
bin/dotnet/sdk-manifests/6.0.100
with the$NUGET_PACKAGES
environment variable. Because we are using NuGet to do this, we hit
some weird problems like extra directories getting created by NuGet:
microsoft.build.notargets
microsoft.netcore.platforms
netstandard.library
A better fix for this problem is to extract the files into:
...and then we move the
WorkloadManifest.*
files to the locations weneed. Any extra files can just be left in
temp
, so they will notcause problems in future builds.
To clean things up more, I removed the
.manifest-6.0.100
string fromthe directory names, so they match what is in dotnet/installer.
I also moved a few MSBuild properties to
Directory.Build.props
sothey could be used throughout the entire repo down the road. This will
assist in making .NET MAUI a workload.
PR Checklist
Does this PR touch anything that might affect accessibility?