Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Allow pages without content #1015

Merged
merged 1 commit into from
May 12, 2021
Merged

[Housekeeping] Allow pages without content #1015

merged 1 commit into from
May 12, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

While doing tests, try to navigate to a page without content (only setting the background color of the page) found a crash. Currently, it would not be possible. This PR adds changes to verify if the page has content or not.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Does this PR touch anything that might affect accessibility?

  • No

@rmarinho rmarinho merged commit d4df78a into main May 12, 2021
@rmarinho rmarinho deleted the fix-empty-page branch May 12, 2021 13:11
rmarinho pushed a commit that referenced this pull request May 12, 2021
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants