Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid and ScrollView don't play well together [iOS, Regression] #15163

Open
espenrl opened this issue May 18, 2023 · 12 comments
Open

Grid and ScrollView don't play well together [iOS, Regression] #15163

espenrl opened this issue May 18, 2023 · 12 comments
Labels
area-controls-button Button, ImageButton area-controls-scrollview ScrollView layout-grid platform/iOS 🍎 s/triaged Issue has been reviewed t/bug Something isn't working
Milestone

Comments

@espenrl
Copy link
Contributor

espenrl commented May 18, 2023

Description

A Grid with a ScrollView and a Button in two separate rows will not allocate the right amount of space to the button when the scrollview contains content larger than device screen.

Steps to Reproduce

See repro. On iOS the button is not being shown properly.

image
Windows

image
iOS

Link to public reproduction project repository

https://github.com/espenrl/issue-repro/tree/main/maui-grid

Version with bug

7.0.86

Last version that worked well

7.0.59

Affected platforms

iOS

Affected platform versions

iOS 16

Did you find any workaround?

No response

Relevant log output

No response

@espenrl espenrl added the t/bug Something isn't working label May 18, 2023
@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label May 18, 2023
@espenrl espenrl changed the title Grid doesn't react to IsVisible changes on children [iOS] Grid and ScrollView don't play well together [iOS, Regression] May 18, 2023
@MGohil
Copy link

MGohil commented May 19, 2023

Maui Team,

This is one of the critical bug where it has affected lot of my app pages, where we have button at the bottom.
User can't navigate to other pages. There is no better workaround to this issue where we need scrolable content with a button at bottom by using scrollview and grid with RowDefinitions= "*, Auto"

This happened after I updated .NET Maui on 18th May, 2023 with 7.0.302.

It would be great if we put this on priority and fix ASAP.

FYI: @breenbob

@SagarPanwala
Copy link

Happening for me as well.

@Keflon
Copy link

Keflon commented May 19, 2023

I reported what looks like the same problem #15085
It turns out it's a duplicate of #15079
and has already been fixed by #14176
:)

@espenrl
Copy link
Contributor Author

espenrl commented May 19, 2023

I reported what looks like the same problem #15085 It turns out it's a duplicate of #15079 and has already been fixed by #14176 :)

Thanks for the headsup @Keflon It was working fine in 7.0.59 which predates that PR though.

@JonnySKK
Copy link

Although it seems to be fixed, we are still waiting for the next service release, so hopefully they put out one soon for .NET 7 to resolve this

@fgiacomelli
Copy link

Same problem for me, really critical, because in an app there could be a lot of layouts with a grid declared with *,Auto where the second row is placed on bottom of the page

@omghb
Copy link

omghb commented May 26, 2023

It broke a lot pages in our App on iOS since we upgraded from 7.0.59 to 7.0.86. It's critical as the App is not usable on iOS anymore. So far we have not found any workarounds.

CRITICAL: Please, fix this soon and deploy it with a SR for 7.0.

@AnnYang01
Copy link

Verified this on Visual Studio Enterprise 17.7.0 Preview 3.0 in iOS 16.4 . This issue not repro on .NET 7.0 and .NET 8.0 with below Project:
MauiApp2.zip
screenshot in .NET 8.0:
image
screenshot in .NET 7.0:
image

@AnnYang01 AnnYang01 added s/triaged Issue has been reviewed s/try-latest-version Please try to reproduce the potential issue on the latest public version labels Jul 17, 2023
@ghost
Copy link

ghost commented Jul 17, 2023

Hi @espenrl. We have added the "s/try-latest-version" label to this issue, which indicates that we'd like you to try and reproduce this issue on the latest available public version. This can happen because we think that this issue was fixed in a version that has just been released, or the information provided by you indicates that you might be working with an older version.

You can install the latest version by installing the latest Visual Studio (Preview) with the .NET MAUI workload installed. If the issue still persists, please let us know with any additional details and ideally a reproduction project provided through a GitHub repository.

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@omghb
Copy link

omghb commented Jul 17, 2023

I just tried the latest released MAUI version 7.0.92. Unfortunately, I still see this issue in our App on an iPhone 13 (iOS 16.4.1).

The bottom area is only half visible on pages where the ScrollView contains much content so that scrolling is required.

Update: Now, I used the sample provided by @espenrl and still see the issue reported in his post. This was not fixed by the latest MAUI 7 SR.

Update 2: When I tried the sample it was using the previous MAUI version 7.0.86. I thought that the latest VS 17.6.5 update has the new MAUI version already included. That was not the case.

@espenrl
Copy link
Contributor Author

espenrl commented Jul 19, 2023

This issue is resolved in 7.0.92 and doesn't reproduce with the sample I provided.

@ghost ghost removed the s/try-latest-version Please try to reproduce the potential issue on the latest public version label Jul 19, 2023
@omghb
Copy link

omghb commented Jul 25, 2023

Our App still shows this issue with MAUI 7.0.92. But in our case it is because we are using additional the On<iOS>().SetUseSafeArea(false); setting. See:

However, both issues might be related as the effects are the same.

@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Feb 1, 2024
@Eilon Eilon removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter labels May 10, 2024
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-button Button, ImageButton area-controls-scrollview ScrollView layout-grid platform/iOS 🍎 s/triaged Issue has been reviewed t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests