Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression/7.0.86] On iOS grid rows that are set to star display as auto when view is added later that spans all rows and columns #15079

Closed
JohnHDev opened this issue May 14, 2023 · 6 comments · Fixed by #14176
Assignees
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-7.0.92 Look for this fix in 7.0.92! fixed-in-7.0.100 fixed-in-7.0.101 fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! i/regression This issue described a confirmed regression on a currently supported version platform/iOS 🍎 t/bug Something isn't working

Comments

@JohnHDev
Copy link

JohnHDev commented May 14, 2023

Description

After updating to 7.0.86 we are seeing an issue when adding a menu overlay to page grids.

The page overlay is effectively a menu system we are converting from Xamarin Forms where we detect the view the user has long tapped on and display an opaque view on top with a menu of options the user can perform.

The page grid is a simple enough layout, an auto row 0 (a toolbar), a star row 1 (for data), and auto row 2 (quick navigation options). Within row 1 we display another grid with 5 or 6 star rows, and each of those contains a scrollview. This allows the user to scroll data within each row if there is more information to display.

When adding the page overlay to the page grid we span all its columns and rows. Worked perfectly previously, but now all the rows within the page expand and display all the data within the scrollview as if they were auto.

Steps to Reproduce

This will be a pain to create a repo, but Im happy to share video, screenshots, or even a TestFlight build to demo the issue.
I could at a push invite someone to the app repo in Azure DevOps but I will want to speak to someone first.

Link to public reproduction project repository

Nope

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

iOS all

Did you find any workaround?

Previous Maui versions worked, so the latest grid fixes appear to have broken something else.
EDIT:
Adding <MauiVersion>7.0.59</MauiVersion> to the project and the grid behaves correctly.
7.0.86 fixes a lot of other layout issues btw.

Relevant log output

No response

@JohnHDev JohnHDev added the t/bug Something isn't working label May 14, 2023
@rmarinho rmarinho added i/regression This issue described a confirmed regression on a currently supported version area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter labels May 15, 2023
@rmarinho
Copy link
Member

@JohnHDev anyway you can try isolate the issue, this seems a very specific scenario. Adding screenshots and videos of the behaviour or maybe just post some of the code you are using will help us a lot identifying the issue.

@hartez anything that pops here about the weird behaviour ?

@rmarinho rmarinho added this to the .NET 7 + Servicing milestone May 15, 2023
@samhouts samhouts changed the title On iOS grid rows that are set to star display as auto when view is added later that spans all rows and columns [regression/7.0.86] On iOS grid rows that are set to star display as auto when view is added later that spans all rows and columns May 15, 2023
@samhouts
Copy link
Member

same as or similar to #15018?

@samhouts
Copy link
Member

There's a repro in #15085

@JohnHDev
Copy link
Author

@samhouts could very well be related to #15085, good spot!

Im happy to try an updated handler if it helps debug the issue when its available.

@hartez
Copy link
Contributor

hartez commented May 18, 2023

This was fixed by #14176

@Hooterr
Copy link

Hooterr commented Jun 15, 2023

So what that it's fixed in preview? It'll be available in November. PLEASE reopen this issue as it's critical and must be fixed ASAP.

@samhouts samhouts added the fixed-in-7.0.92 Look for this fix in 7.0.92! label Jul 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-7.0.92 Look for this fix in 7.0.92! fixed-in-7.0.100 fixed-in-7.0.101 fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! i/regression This issue described a confirmed regression on a currently supported version platform/iOS 🍎 t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants