[Rgen] Add support for the Methods/Constructors in the transformer. #22162

mandel-macaque · 2025-02-11T22:44:06Z

Add the parsing of methods and constructor in the data model for the transformer.

github-actions · 2025-02-11T22:48:12Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

Add the parsing of methods and constructor in the data model for the transformer.

vs-mobiletools-engineering-service2 · 2025-02-12T23:43:09Z

✅ [PR Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 444298503ec6e074bffaada506998965f7507d9b [PR build]

vs-mobiletools-engineering-service2 · 2025-02-12T23:58:18Z

✅ [PR Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 444298503ec6e074bffaada506998965f7507d9b [PR build]

vs-mobiletools-engineering-service2 · 2025-02-13T00:15:48Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 444298503ec6e074bffaada506998965f7507d9b [PR build]

vs-mobiletools-engineering-service2 · 2025-02-13T00:17:45Z

✅ [PR Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 444298503ec6e074bffaada506998965f7507d9b [PR build]

vs-mobiletools-engineering-service2 · 2025-02-13T00:32:16Z

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 444298503ec6e074bffaada506998965f7507d9b [PR build]

vs-mobiletools-engineering-service2 · 2025-02-13T00:33:30Z

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 444298503ec6e074bffaada506998965f7507d9b [PR build]

vs-mobiletools-engineering-service2 · 2025-02-13T00:33:50Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 444298503ec6e074bffaada506998965f7507d9b [PR build]

vs-mobiletools-engineering-service2 · 2025-02-13T00:34:54Z

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 444298503ec6e074bffaada506998965f7507d9b [PR build]

vs-mobiletools-engineering-service2 · 2025-02-13T02:29:39Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 112 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 444298503ec6e074bffaada506998965f7507d9b [PR build]

vs-mobiletools-engineering-service2 · 2025-02-13T04:09:02Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 444298503ec6e074bffaada506998965f7507d9b [PR build]

StephaneDelcroix

minor nits. fix that only if it matters to you

StephaneDelcroix · 2025-02-13T07:55:48Z

src/rgen/Microsoft.Macios.Generator/DataModel/Constructor.cs

@@ -110,6 +112,8 @@ public override int GetHashCode ()
 	public override string ToString ()
 	{
 		var sb = new StringBuilder ($"{{ Ctr: Type: {Type}, ");
+		sb.Append ($"ExportMethodData: {ExportMethodData}, ");


it feels strange to override ToString() for generating code. wouldn't it be clearer to name it ToDisplayString() ? (and add ToString() to the banned API list, making sure it's not used ?)

StephaneDelcroix · 2025-02-13T07:56:45Z

src/rgen/Microsoft.Macios.Generator/DataModel/Method.cs

@@ -122,7 +122,7 @@ public override string ToString ()
 		sb.Append ($"ReturnType: {ReturnType}, ");
 		sb.Append ($"SymbolAvailability: {SymbolAvailability}, ");
 		sb.Append ($"ExportMethodData: {ExportMethodData}, ");
-		sb.Append ($"BindAs: {BindAs}, ");
+		sb.Append ($"BindAs: {BindAs?.ToString () ?? "null"}, ");


and eventually share / reuse some of the logic ?

StephaneDelcroix · 2025-02-13T07:58:26Z

src/rgen/Microsoft.Macios.Transformer/DataModel/Binding.Transformer.cs

+	internal static bool Skip (MethodDeclarationSyntax methodDeclarationSyntax, SemanticModel semanticModel)
+	{
+		var methodSymbol = semanticModel.GetDeclaredSymbol (methodDeclarationSyntax);
+		if (methodSymbol is null)


that's a one liner on which I'd still add curly braces (due to the comment)

StephaneDelcroix · 2025-02-13T08:02:09Z

src/rgen/Microsoft.Macios.Transformer/DataModel/Binding.Transformer.cs

+			.Select (m => m.ToConstructor ())
+			.Where (c => c is not null)
+			.Select (c => c!.Value)
+			.ToImmutableArray ();


3 Wheres, 2 Selects. A LINQ query that could have been a for loop (for perf reasons). but the meaning is quite clear...

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Feb 12, 2025

View reviewed changes

rolfbjarne approved these changes Feb 12, 2025

View reviewed changes

mandel-macaque force-pushed the dev/mandel/transformer-data-model-properties branch from 709f005 to 0583b1e Compare February 12, 2025 11:32

Base automatically changed from dev/mandel/transformer-data-model-properties to main February 12, 2025 22:24

[Rgen] Add support for the Methods/Constructors in the transformer.

4442985

Add the parsing of methods and constructor in the data model for the transformer.

mandel-macaque force-pushed the dev/mandel/transformer-data-model-methods-constructors branch from 9060727 to 4442985 Compare February 12, 2025 22:30

StephaneDelcroix approved these changes Feb 13, 2025

View reviewed changes

mandel-macaque merged commit 29c2d78 into main Feb 13, 2025
46 checks passed

mandel-macaque deleted the dev/mandel/transformer-data-model-methods-constructors branch February 13, 2025 12:51

[Rgen] Add support for the Methods/Constructors in the transformer. #22162

[Rgen] Add support for the Methods/Constructors in the transformer. #22162

Conversation

mandel-macaque commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 12, 2025

✅ [PR Build] Build passed (Detect API changes) ✅

vs-mobiletools-engineering-service2 commented Feb 12, 2025

✅ [PR Build] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Feb 13, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Feb 13, 2025

✅ [PR Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Feb 13, 2025

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Feb 13, 2025

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Feb 13, 2025

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Feb 13, 2025

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Feb 13, 2025

🚀 [CI Build] Test results 🚀

Test results

Tests counts

vs-mobiletools-engineering-service2 commented Feb 13, 2025

💻 [CI Build] Windows Integration Tests passed 💻

StephaneDelcroix left a comment

Choose a reason for hiding this comment

StephaneDelcroix Feb 13, 2025

Choose a reason for hiding this comment

StephaneDelcroix Feb 13, 2025

Choose a reason for hiding this comment

StephaneDelcroix Feb 13, 2025

Choose a reason for hiding this comment

StephaneDelcroix Feb 13, 2025

Choose a reason for hiding this comment