Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the creation of ONNX initializers #965
Allow the creation of ONNX initializers #965
Changes from 4 commits
9a46e85
d2abc30
d109e1e
0d782bd
3753597
7ace19a
add4f4f
604cd93
ea94b9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add checks? See how above functions do checks. Same for below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var floatScalar = ctx.AddInitializer(9.4f, "float");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better than do
var floatScalar = model.Graph.Initializer[0];
If someone decide to change this test, and add one more initializer in the beginning, it will break tests.
In reply to: 220259227 [](ancestors = 220259227)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctx.AddInitializer returns the ONNX name of a tensor, not the actual ONNX object.
In addition, the test aims at examining the generated ONNX objects under the real scenario. Getting information before finishing the conversion is not ideal because it means we are checking an intermediate state of a conversion instead of the final state we care the most.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use that name of tensor to access initializer instead of model.Graph.Initalizer[0]?
If yes, i would suggest to use names instead of index.
If no, I find it strange, but i'm ok with current code.
In reply to: 220418126 [](ancestors = 220418126)