Skip to content

Fix PositiveRecall optimization in AutoMLExperiment #7493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoshuaSloan
Copy link

BinaryClassificationMetric.PositiveRecall incorrectly returns PositivePrecision.

I noticed this when testing an early stopping pipeline and found that the logged best trial metric did not align with the final model results. This is a self-evident fix (akin to a small typo), so I did not open a new issue for it.

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.99%. Comparing base (d9694c4) to head (4fcb375).

Files with missing lines Patch % Lines
...osoft.ML.AutoML/AutoMLExperiment/IMetricManager.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7493      +/-   ##
==========================================
- Coverage   69.00%   68.99%   -0.01%     
==========================================
  Files        1482     1482              
  Lines      273901   273901              
  Branches    28256    28256              
==========================================
- Hits       189000   188989      -11     
- Misses      77514    77522       +8     
- Partials     7387     7390       +3     
Flag Coverage Δ
Debug 68.99% <0.00%> (-0.01%) ⬇️
production 63.29% <0.00%> (-0.01%) ⬇️
test 89.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...osoft.ML.AutoML/AutoMLExperiment/IMetricManager.cs 51.76% <0.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant