Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated build instructions #5534
Updated build instructions #5534
Changes from 2 commits
4a7c233
27a5f50
8efe3af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files in eng/common are copied directly from Arcade. The next time we take an Arcade update, they are likely to be overwritten. So it is not a good idea to put these changes here.
Can you please find a different mechanism?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is true. I have also explained the list of available configurations in our developer guide here. Would that not be enough, or should we always have the list of available configs printed out during
build -help
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we should probably move away from the custom configurations and instead use "normal" multi-targeting, (i.e.
TargetFrameworks
in the .csproj).We used custom configurations in the past because that's how build-tools required it to be. Now that we are using arcade, and a typical .NET build system, we should be able to only have
Debug
andRelease
configurations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should always have a list of available configs during
build -help
.But as @eerhardt pointed out below, let us switch to the more standard way of doing this. You can do that in a separate PR and leave these files as is.
In reply to: 538670694 [](ancestors = 538670694)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Done.