-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine multiple tree ensemble models into a single tree ensemble #364
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
115 changes: 115 additions & 0 deletions
115
src/Microsoft.ML.FastTree/TreeEnsemble/TreeEnsembleCombiner.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System.Collections.Generic; | ||
using Microsoft.ML.Runtime; | ||
using Microsoft.ML.Runtime.FastTree.Internal; | ||
using Microsoft.ML.Runtime.Internal.Calibration; | ||
|
||
[assembly: LoadableClass(typeof(TreeEnsembleCombiner), null, typeof(SignatureModelCombiner), "Fast Tree Model Combiner", "FastTreeCombiner")] | ||
|
||
namespace Microsoft.ML.Runtime.FastTree.Internal | ||
{ | ||
public sealed class TreeEnsembleCombiner : IModelCombiner<IPredictorProducing<float>, IPredictorProducing<float>> | ||
{ | ||
private readonly IHost _host; | ||
private readonly PredictionKind _kind; | ||
|
||
public TreeEnsembleCombiner(IHostEnvironment env, PredictionKind kind) | ||
{ | ||
_host = env.Register("TreeEnsembleCombiner"); | ||
switch (kind) | ||
{ | ||
case PredictionKind.BinaryClassification: | ||
case PredictionKind.Regression: | ||
case PredictionKind.Ranking: | ||
_kind = kind; | ||
break; | ||
default: | ||
throw _host.ExceptUserArg(nameof(kind), $"Tree ensembles can be either of type {nameof(PredictionKind.BinaryClassification)}, " + | ||
$"{nameof(PredictionKind.Regression)} or {nameof(PredictionKind.Ranking)}"); | ||
} | ||
} | ||
|
||
public IPredictorProducing<float> CombineModels(IEnumerable<IPredictorProducing<float>> models) | ||
{ | ||
_host.CheckValue(models, nameof(models)); | ||
|
||
var ensemble = new Ensemble(); | ||
int modelCount = 0; | ||
int featureCount = -1; | ||
bool binaryClassifier = false; | ||
foreach (var model in models) | ||
{ | ||
modelCount++; | ||
|
||
var predictor = model; | ||
_host.CheckValue(predictor, nameof(models), "One of the models is null"); | ||
|
||
var calibrated = predictor as CalibratedPredictorBase; | ||
double paramA = 1; | ||
if (calibrated != null) | ||
{ | ||
_host.Check(calibrated.Calibrator is PlattCalibrator, | ||
"Combining FastTree models can only be done when the models are calibrated with Platt calibrator"); | ||
predictor = calibrated.SubPredictor; | ||
paramA = -(calibrated.Calibrator as PlattCalibrator).ParamA; | ||
} | ||
var tree = predictor as FastTreePredictionWrapper; | ||
if (tree == null) | ||
throw _host.Except("Model is not a tree ensemble"); | ||
foreach (var t in tree.TrainedEnsemble.Trees) | ||
{ | ||
var bytes = new byte[t.SizeInBytes()]; | ||
int position = -1; | ||
t.ToByteArray(bytes, ref position); | ||
position = -1; | ||
var tNew = new RegressionTree(bytes, ref position); | ||
if (paramA != 1) | ||
{ | ||
for (int i = 0; i < tNew.NumLeaves; i++) | ||
tNew.SetOutput(i, tNew.LeafValues[i] * paramA); | ||
} | ||
ensemble.AddTree(tNew); | ||
} | ||
|
||
if (modelCount == 1) | ||
{ | ||
binaryClassifier = calibrated != null; | ||
featureCount = tree.InputType.ValueCount; | ||
} | ||
else | ||
{ | ||
_host.Check((calibrated != null) == binaryClassifier, "Ensemble contains both calibrated and uncalibrated models"); | ||
_host.Check(featureCount == tree.InputType.ValueCount, "Found models with different number of features"); | ||
} | ||
} | ||
|
||
var scale = 1 / (double)modelCount; | ||
|
||
foreach (var t in ensemble.Trees) | ||
{ | ||
for (int i = 0; i < t.NumLeaves; i++) | ||
t.SetOutput(i, t.LeafValues[i] * scale); | ||
} | ||
|
||
switch (_kind) | ||
{ | ||
case PredictionKind.BinaryClassification: | ||
if (!binaryClassifier) | ||
return new FastTreeBinaryPredictor(_host, ensemble, featureCount, null); | ||
|
||
var cali = new PlattCalibrator(_host, -1, 0); | ||
return new FeatureWeightsCalibratedPredictor(_host, new FastTreeBinaryPredictor(_host, ensemble, featureCount, null), cali); | ||
case PredictionKind.Regression: | ||
return new FastTreeRegressionPredictor(_host, ensemble, featureCount, null); | ||
case PredictionKind.Ranking: | ||
return new FastTreeRankingPredictor(_host, ensemble, featureCount, null); | ||
default: | ||
_host.Assert(false); | ||
throw _host.ExceptNotSupp(); | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this. We should add a test for this function. I believe this function is not used when saving the tree model to disk and reading it back in TrainTest or CV, hence it was not caught during testing. #Resolved