-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary classification samples update #3311
Conversation
Noticed that I forgot to add |
...es/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/BinaryClassification.ttinclude
Outdated
Show resolved
Hide resolved
all checklist points are done. please also add #6 (it's in the checklist with example links): When you do that might want to rename this line: var model = pipeline.Fit(trainingData); Refers to: docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/BinaryClassification.ttinclude:11 in ace5d1b. [](commit_id = ace5d1b, deletion_comment = False) |
docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/PriorTrainer.cs
Outdated
Show resolved
Hide resolved
please also exclude libmf change in this PR #Closed |
i like this PR very much :) #Resolved |
Add reference to: // This example requires installation of additional nuget package <a href="https://www.nuget.org/packages/Microsoft.ML.LightGbm/">Microsoft.ML.LightGbm</a>. For |
...es/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/BinaryClassification.ttinclude
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/LightGbm.cs
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/LinearSvm.cs
Outdated
Show resolved
Hide resolved
ace5d1b
to
b35f349
Compare
Codecov Report
@@ Coverage Diff @@
## master #3311 +/- ##
==========================================
- Coverage 72.7% 72.69% -0.01%
==========================================
Files 807 807
Lines 145172 145172
Branches 16225 16225
==========================================
- Hits 105541 105529 -12
- Misses 35217 35227 +10
- Partials 4414 4416 +2
|
8668701
to
11ffadd
Compare
Tracked in #2522.
In this PR I use the templates for binary classification samples to eliminate the dependency on the SamplesUtils and make the samples standalone.
Some binary classification trainers did not have samples, so I added them.
Note: This PR does not take care of FFM on which @wschin will be working.