Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadable attribute for LinearMulticlassModelParameters #3217

Conversation

Ivanidzo4ka
Copy link
Contributor

fixes #3209.

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #3217 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3217      +/-   ##
==========================================
+ Coverage    72.6%   72.62%   +0.01%     
==========================================
  Files         807      807              
  Lines      145077   145080       +3     
  Branches    16213    16213              
==========================================
+ Hits       105337   105366      +29     
+ Misses      35322    35297      -25     
+ Partials     4418     4417       -1
Flag Coverage Δ
#Debug 72.62% <100%> (+0.01%) ⬆️
#production 68.17% <ø> (+0.02%) ⬆️
#test 88.92% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...LogisticRegression/MulticlassLogisticRegression.cs 67.61% <ø> (+1.74%) ⬆️
.../Microsoft.ML.Tests/TrainerEstimators/SdcaTests.cs 97.31% <100%> (+0.05%) ⬆️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.26% <0%> (+0.15%) ⬆️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 91.12% <0%> (+1.02%) ⬆️
...oft.ML.StandardTrainers/StandardTrainersCatalog.cs 92.34% <0%> (+3.27%) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 100% <0%> (+20.51%) ⬆️

@@ -31,6 +31,10 @@
"Multiclass LR Executor",
MaximumEntropyModelParameters.LoaderSignature)]

[assembly: LoadableClass(typeof(LinearMulticlassModelParameters), null, typeof(SignatureLoadModel),
"Multiclass LR No Prob",
Copy link
Member

@abgoswam abgoswam Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Prob [](start = 19, length = 7)

should we say "no calibration" or "raw scores" or "logits" ?

right now it could be interpreted as "no problem" :)

Copy link
Contributor Author

@Ivanidzo4ka Ivanidzo4ka Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid we have limit in 26 chars for this string, and no calibration doesn't fit.
I'm fine with Raw score, but I would prefer to @wschin comment on this one, since he was one who split them apart

Copy link
Member

@wschin wschin Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Multiclass LR No Cali",

Copy link
Member

@abgoswam abgoswam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka Ivanidzo4ka merged commit 7e0cc46 into dotnet:master Apr 5, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants