-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loadable attribute for LinearMulticlassModelParameters #3217
Add loadable attribute for LinearMulticlassModelParameters #3217
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3217 +/- ##
==========================================
+ Coverage 72.6% 72.62% +0.01%
==========================================
Files 807 807
Lines 145077 145080 +3
Branches 16213 16213
==========================================
+ Hits 105337 105366 +29
+ Misses 35322 35297 -25
+ Partials 4418 4417 -1
|
@@ -31,6 +31,10 @@ | |||
"Multiclass LR Executor", | |||
MaximumEntropyModelParameters.LoaderSignature)] | |||
|
|||
[assembly: LoadableClass(typeof(LinearMulticlassModelParameters), null, typeof(SignatureLoadModel), | |||
"Multiclass LR No Prob", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No Prob [](start = 19, length = 7)
should we say "no calibration" or "raw scores" or "logits" ?
right now it could be interpreted as "no problem" :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid we have limit in 26 chars for this string, and no calibration
doesn't fit.
I'm fine with Raw score
, but I would prefer to @wschin comment on this one, since he was one who split them apart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Multiclass LR No Cali",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes #3209.