-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate nuget packaging into Stable and Experimental #2951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @maryamariyan .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to add the other assemblies to the list. And also fix the property so it is statically defined.
Codecov Report
@@ Coverage Diff @@
## master #2951 +/- ##
==========================================
+ Coverage 72.27% 72.27% +<.01%
==========================================
Files 796 802 +6
Lines 142304 142901 +597
Branches 16049 16134 +85
==========================================
+ Hits 102849 103287 +438
- Misses 35075 35199 +124
- Partials 4380 4415 +35
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for the good work on this, @maryamariyan.
StableProjects
property in a newStablePackagesInfo.props
file, which has name of stable projects separated by semicolon.BranchInfo.props
, calledBranchInfo.Stable.props
. The files contain version information. Either of the two would be used depending on whether or not a project is listed inStableProjects
property.Currently
BranchInfo.props
generates0.12.0-preview
for all projects. The Major/Minor/Patch versions to set for stable projects are specified inBranchInfo.Stable.props
and have identical values toBranchInfo.props
until we decide to change them in the near future.Fixes: #2279
cc: @eerhardt @TomFinley @Ivanidzo4ka @sfilipi @Anipik