Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of components through MLContext and cleanup (Concat, Normalizer, NA Indicator/Replace) #2363

Merged
merged 8 commits into from
Feb 5, 2019

Conversation

artidoro
Copy link
Contributor

@artidoro artidoro commented Feb 1, 2019

This PR is part of the work outlined in #1798, and focuses on the Concat, Normalizer, NA Indicator/Replace transformers/estimators:

  1. Internalize constructors of estimators and transformers
  2. Keep ColumnInfo and move it to to the estimators The ColumnInfo structure should live in the estimators, rather than transformers #1760
  3. Rename Arguments -> Options
  4. Internalize Options only when they are not used by public constructor. For all other cases, retain Options as public Arguments class should be made internal when possible #1758

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@617f7f6). Click here to learn what that means.
The diff coverage is 89.47%.

@@            Coverage Diff            @@
##             master    #2363   +/-   ##
=========================================
  Coverage          ?   71.25%           
=========================================
  Files             ?      785           
  Lines             ?   140911           
  Branches          ?    16106           
=========================================
  Hits              ?   100406           
  Misses            ?    36038           
  Partials          ?     4467
Flag Coverage Δ
#Debug 71.25% <89.47%> (?)
#production 67.61% <86.66%> (?)
#test 85.3% <94.28%> (?)

@artidoro artidoro self-assigned this Feb 1, 2019
@artidoro artidoro added the API Issues pertaining the friendly API label Feb 1, 2019
@sfilipi
Copy link
Member

sfilipi commented Feb 1, 2019

public sealed class ColumnConcatenatingTransformer : RowToRowTransformerBase

one line XML comment; take it form the xtension method. #Closed


Refers to: src/Microsoft.ML.Data/Transforms/ColumnConcatenatingTransformer.cs:36 in 29cd1ba. [](commit_id = 29cd1ba, deletion_comment = False)

/// <summary>
/// Returns the <see cref="SchemaShape"/> of the schema which will be produced by the transformer.
/// Used for schema propagation and verification in a pipeline.
/// </summary>
public SchemaShape GetOutputSchema(SchemaShape inputSchema)
Copy link
Member

@wschin wschin Feb 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetOutputSchema [](start = 27, length = 15)

Not a request and probably not related to you. Just feel if we could have documentations for how we compute SchemaShape in GetOutputSchema, we might have documented everything needed by users. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, although I think we should write that in the constructor, or the summary for the class itself. I think we should add it as part of another PR that focuses on improving doc, my PR is a larger set of changes focused on internalization and adding minimal documentation where it was not present.


In reply to: 253243462 [](ancestors = 253243462)

@sfilipi
Copy link
Member

sfilipi commented Feb 5, 2019

    public IReadOnlyList<(string outputColumnName, string inputColumnName)> Columns => ColumnPairs.AsReadOnly();

xml #Resolved


Refers to: src/Microsoft.ML.Transforms/MissingValueIndicatorTransformer.cs:81 in 183def8. [](commit_id = 183def8, deletion_comment = False)

Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@abgoswam
Copy link
Member

abgoswam commented Feb 5, 2019

    public sealed class Column : OneToOneColumn

internal ? #Resolved


Refers to: src/Microsoft.ML.Transforms/MissingValueHandlingTransformer.cs:77 in 183def8. [](commit_id = 183def8, deletion_comment = False)

Copy link
Member

@wschin wschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to 🚢

@artidoro
Copy link
Contributor Author

artidoro commented Feb 5, 2019

    public sealed class Column : OneToOneColumn

Same here, I made the entire class internal so this is not an issue.


In reply to: 460744082 [](ancestors = 460744082)


Refers to: src/Microsoft.ML.Transforms/MissingValueHandlingTransformer.cs:77 in 183def8. [](commit_id = 183def8, deletion_comment = False)

@artidoro artidoro merged commit 58ff9b5 into dotnet:master Feb 5, 2019
@artidoro artidoro deleted the catmiss branch March 13, 2019 17:55
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants