-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation of components through MLContext and cleanup (Concat, Normalizer, NA Indicator/Replace) #2363
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2363 +/- ##
=========================================
Coverage ? 71.25%
=========================================
Files ? 785
Lines ? 140911
Branches ? 16106
=========================================
Hits ? 100406
Misses ? 36038
Partials ? 4467
|
src/Microsoft.ML.Data/Transforms/ColumnConcatenatingEstimator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Transforms/ColumnConcatenatingEstimator.cs
Outdated
Show resolved
Hide resolved
/// <summary> | ||
/// Returns the <see cref="SchemaShape"/> of the schema which will be produced by the transformer. | ||
/// Used for schema propagation and verification in a pipeline. | ||
/// </summary> | ||
public SchemaShape GetOutputSchema(SchemaShape inputSchema) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetOutputSchema [](start = 27, length = 15)
Not a request and probably not related to you. Just feel if we could have documentations for how we compute SchemaShape
in GetOutputSchema
, we might have documented everything needed by users. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, although I think we should write that in the constructor, or the summary for the class itself. I think we should add it as part of another PR that focuses on improving doc, my PR is a larger set of changes focused on internalization and adding minimal documentation where it was not present.
In reply to: 253243462 [](ancestors = 253243462)
src/Microsoft.ML.Data/Transforms/ColumnConcatenatingTransformer.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time to 🚢
Same here, I made the entire class internal so this is not an issue. In reply to: 460744082 [](ancestors = 460744082) Refers to: src/Microsoft.ML.Transforms/MissingValueHandlingTransformer.cs:77 in 183def8. [](commit_id = 183def8, deletion_comment = False) |
This PR is part of the work outlined in #1798, and focuses on the Concat, Normalizer, NA Indicator/Replace transformers/estimators: