-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API overview: added AsDynamic call #1139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pkulikov for your contribution!
Unfortunately, it's the overview that need updating, not the cookbook. The cookbook code is correct.
If you would make the change in the overview doc, I would be happy to approve.
@Zruty0 OK, I'll make the update in the overview. |
@Zruty0 I've updated the overview example. #Closed |
docs/code/MlNetCookBook.md
Outdated
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`` [](start = 1, length = 2)
nitpicking: please remove the trailing whitespace :) #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zruty0 fixed both :). Seems that GitHub web interface adds a blank line at the end on a commit. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. Well, I suppose we'll end up with these anyway, if that's what automation is doing. In any case, thanks!
In reply to: 222460113 [](ancestors = 222460113)
docs/code/MlNetHighLevelConcepts.md
Outdated
The prediction function is *not re-entrant / thread-safe*: if you want to conduct predictions simultaneously with multiple threads, you need to have a prediction function per thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d. [](start = 180, length = 2)
Trailing whitespace again :) #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example at the end of the overview of new ML.NET API doesn't use
AsDynamic
:So, it looks that the
AsDynamic
call in the cookbook example is not necessary.