Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Onnx and TensorFlow projects to console project #1099

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Add Onnx and TensorFlow projects to console project #1099

merged 1 commit into from
Sep 30, 2018

Conversation

Ivanidzo4ka
Copy link
Contributor

fixes #1081

abgoswam
abgoswam approved these changes Sep 29, 2018
View reviewed changes
Copy link
Member

@abgoswam abgoswam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@abgoswam
Copy link
Member

Thanks @Ivanidzo4ka

yaeldekel
yaeldekel reviewed Sep 30, 2018
View reviewed changes
src/Microsoft.ML.Console/Microsoft.ML.Console.csproj
<ProjectReference Include="..\Microsoft.ML.Transforms\Microsoft.ML.Transforms.csproj" />

<NativeAssemblyReference Include="FastTreeNative" />
<NativeAssemblyReference Include="CpuMathNative" />
<NativeAssemblyReference Include="FactorizationMachineNative" />
<NativeAssemblyReference Include="LdaNative" />
<NativeAssemblyReference Include="SymSgdNative" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SymSgdNative [](start = 38, length = 12)

Do we also need to add the native TF and Onnx assemblies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have proper references to Nuget in your project - NO. These native references for files we build in our solution, and I don't think we build anything for ONNX ans TensorFlow

justinormont
justinormont approved these changes Sep 30, 2018
View reviewed changes
Copy link
Contributor

@justinormont justinormont left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I wonder if there's an easy method of adding a test which checks all interfaces/APIs to see that all components are available in each? It would be nice to automate this process so missing components don't occur in the future.

@justinormont justinormont merged commit f124d69 into dotnet:master Sep 30, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yaeldekel yaeldekel yaeldekel left review comments

@justinormont justinormont justinormont approved these changes

@abgoswam abgoswam abgoswam approved these changes

@jignparm jignparm Awaiting requested review from jignparm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TensorFlowTransform & ONNXTransform not displaying in command-line
4 participants
@Ivanidzo4ka @abgoswam @justinormont @yaeldekel