Add a workaround for the tests hanging while loading MKL. #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinormont
approved these changes
Sep 27, 2018
The workaround is to ensure the MKL library is loaded very early in the test process, so it doesn't cause the deadlock. Also moving the test queue back to the hosted windows pool. Workaround dotnet#1073
eerhardt
force-pushed
the
WorkaroundMklHang
branch
from
799ae67 to
52ee74a
Compare
eerhardt
changed the title
eerhardt
changed the title
|
Taking WIP off. This PR is ready for merge. |
shauheen
approved these changes
Oct 1, 2018
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround is to ensure the MKL library is loaded very early in the test process, so it doesn't cause the deadlock.
Workaround #1073
Another deadlock also occurs when running TestAutoInference and TestPipelineSweeper in parallel. Marking these tests to not run in parallel anymore.
Workaround #1095
Moving back to the Azure Hosted VS2017 pool to run the tests now that we've narrowed the deadlocks down.