Remove DnnAnalyzer from the Microsoft.ML.TensorFlow nuget #1029
Conversation
There was a problem hiding this comment.
Thanks much @yaeldekel ! You're an inspiration to our organization.
| @@ -4,7 +4,6 @@ | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFramework>netcoreapp2.0</TargetFramework> | |||
| <AssemblyName>DnnAnalyzer</AssemblyName> | |||
| <IncludeInPackage>Microsoft.ML.TensorFlow</IncludeInPackage> | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
There was a problem hiding this comment.
Existing Issue: if you want this project to work on Linux/Mac you also need tensorflow_framework below, similar to
.
There was a problem hiding this comment.
@yaeldekel I think this needs to be updated.
There was a problem hiding this comment.
I'm not sure fixing this issue is 100% necessary for 0.6 since we aren't going to be shipping DnnAnalyzer in 0.6.
| @@ -4,7 +4,6 @@ | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFramework>netcoreapp2.0</TargetFramework> | |||
There was a problem hiding this comment.
netcoreapp2.0 [](start = 21, length = 13)
Comment from @eerhardt from previous PR:
This should be netcoreapp2.1. Note that netcoreapp and netstandard are different things. We want netcoreapp2.1 for any and all executables and tests. We want netstandard2.0 for any libraries.
Unrelated to your problem, but if you decide to make changes, why not fix it as well :)
There was a problem hiding this comment.
I'd prefer we just nuke this thing altogether and recast it as an ICommand. It should have been one anyway.
ghost
locked as resolved and limited conversation to collaborators
Fixes #1027 .