Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Scenario tests... #32

Closed
zeahmed opened this issue May 5, 2018 · 2 comments
Closed

Refactor Scenario tests... #32

zeahmed opened this issue May 5, 2018 · 2 comments

Comments

@zeahmed
Copy link
Contributor

zeahmed commented May 5, 2018

Issue: In Scenarios, there is a class named "Top5Scenarios"
Depending on how you count, there are either 2 or 4 scenarios.
It is recommended renaming the class.

Let's also review the names of the files and make sure they are descriptive.
@zeahmed zeahmed mentioned this issue May 5, 2018
Closed
@markusweimer markusweimer changed the title Refectore Scenario tests... Refactor Scenario tests... May 7, 2018
@zeahmed zeahmed mentioned this issue May 7, 2018
Merged
glebuk pushed a commit that referenced this issue May 8, 2018
@zeahmed @glebuk
Refactored scenario tests (issue #32) (#52)
500d703 
* Refectored scenario tests according to #Bug 240688: Scenarios has a class Top5Scenarios with 2 scenarios defined

* Moved 'TrainAndPredictHousePriceModelTest' to separate file.
This closes issue #32
@glebuk
Copy link
Contributor

glebuk commented May 8, 2018

PR 52 closed this
#52

@glebuk glebuk closed this as completed May 8, 2018
@m-a-i-n-g-i
Copy link

m-a-i-n-g-i commented May 8, 2018 •
edited
Loading

@glebuk
Just a quick heads up letting you know that landing this PR #52 just broke one of the links on the main README.md

  • Go to the Examples section and try following the link sending you to the complete sample. Here's the markdown snippet.
## Examples

Here's an example of code to train a model to predict sentiment from text samples. (You can see the complete sample [here](https://github.com/dotnet/machinelearning/blob/master/test/Microsoft.ML.Tests/Scenarios/Scenario3_SentimentPrediction.cs)):

Cheers!

eerhardt pushed a commit to eerhardt/machinelearning that referenced this issue Jul 27, 2018
@zeahmed @eerhardt
Refactored scenario tests (issue dotnet#32) (dotnet#52)
8a7725a 
* Refectored scenario tests according to #Bug 240688: Scenarios has a class Top5Scenarios with 2 scenarios defined

* Moved 'TrainAndPredictHousePriceModelTest' to separate file.
This closes issue dotnet#32
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m-a-i-n-g-i @glebuk @zeahmed