-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move IDataView into Microsoft.ML namespace #2974
Comments
With solving this, I think it would be safe to reconcile one more issue: the separation of the base DataViewTypes (like Note: this means that |
@shauheen Shall we make this part of Project 13? This seems like the sort of thing we must solve before 1.0. |
Should this proceed as proposed it certainly will be Project 13. |
* Move IDataView into Microsoft.ML namespace Fix #2974 * Fix code analyzer test now that we removed a using line.
We've received feedback that having
IDataView
in theMicrosoft.Data
namespace (which was done in #2220) is confusing to users. Traditionally, theSystem.Data
namespace has been populated with "database" specific technologies.Microsoft.Data
isn't all that different fromSystem.Data
, and one could argue they are basically the "same thing", with theSystem.Data
technologies being inside of the BCL and/ornetstandard
definition whileMicrosoft.Data
being built outside of the BCL/netstandard
definition. There are already "database" specific APIs inMicrosoft.Data
, for example https://docs.microsoft.com/en-us/dotnet/api/microsoft.data.sqlite.System.Data
even already has aDataView
class, andIDataView
andDataView
are drastically different.To solve this confusion, we should rename the
Microsoft.Data.DataView
NuGet package toMicrosoft.ML.DataView
and move theMicrosoft.Data.DataView
namespace underMicrosoft.ML
. The NuGet package will still be separated from the algorithms and transforms in the largerMicrosoft.ML
NuGet package. So the value of #1860 can still be realized. The separate package will just be brandedML
instead ofData
./cc @TomFinley @shauheen @markusweimer @glebuk
The text was updated successfully, but these errors were encountered: