This repository has been archived by the owner on Mar 15, 2022. It is now read-only.
Implement overflow forms of binary arithmetic #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map these to the appropriate LLVM intrinsics that detect overflow and compute results together. Also annotate the invalid type/opcode combinations in the operator map (floats don't have bitwise operations or unsigned or overflow variants). Closes #65
|
LGTM. |
|
Green |
JosephTremoulet
added a commit
that referenced
this pull request
Mar 23, 2015
Implement overflow forms of binary arithmetic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement overflow forms of binary arithmetic
Map these to the appropriate LLVM intrinsics that detect overflow and compute results together.
Also annotate the invalid type/opcode combinations in the operator map (floats don't have bitwise operations or unsigned or overflow variants).
Closes #65
The two methods in each bring-up test currently failing on binary op overflow now fail on localAlloc instead.