Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Implement adding null check for this call #202

Merged
merged 1 commit into from
Feb 25, 2015
Merged

Implement adding null check for this call #202

merged 1 commit into from
Feb 25, 2015

Conversation

kyulee1
Copy link
Contributor

@kyulee1 kyulee1 commented Feb 25, 2015

This implements adding null check for this call utilizing the latest null check implementation.
Since this only applies to this argument, I moved the check inside the loop that builds arguments.

@kyulee1
Copy link
Contributor Author

kyulee1 commented Feb 25, 2015

@JosephTremoulet PTAL

@pgavlin
Copy link
Contributor

pgavlin commented Feb 25, 2015

FYI, PR #201 also contains baseline adjustments. You should probably wait to merge until that PR is merged, then rebase your changes and generate new baselines for the tests.

@libengu
Copy link

libengu commented Feb 25, 2015

@kyulee1 I think the reason your baseline does not pick up the latest CoreCLR assembly change is your CoreCLRTestAssets is out-dated. You probably need to delete your CoreCLRTestAssets directory and start a new session. And then you do what you need to do originally.

@kyulee1
Copy link
Contributor Author

kyulee1 commented Feb 25, 2015

Should build system/framework check if it is out-dated and update it accordingly?

@JosephTremoulet
Copy link
Contributor

Code changes look good to me.

@libengu
Copy link

libengu commented Feb 25, 2015

@kyulee1 I think so. Will figure out whether there is a better way.

@libengu
Copy link

libengu commented Feb 25, 2015

@kyulee1 This issue is different from getting a latest CoreCLR test assets. This problem is because CoreCLR upgraded some of the assembly they NuGet during buildtest. At this point, I have no way to detect this automatically. I will talk to CoreCLR side to see if we can do anything here.

@libengu
Copy link

libengu commented Feb 25, 2015

@kyulee1 Please go ahead with your original commit. PR #201 build failed. It looks like lab does not see the new assembly change. Need to look deeper to see what caused this.

kyulee1 added a commit that referenced this pull request Feb 25, 2015
Implement adding null check for this call
@kyulee1 kyulee1 merged commit 5cf887c into dotnet:master Feb 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants