Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Verify we're not skipping methods in the enabled tests #821

Closed
AndyAyersMS opened this issue Sep 4, 2015 · 6 comments
Closed

Verify we're not skipping methods in the enabled tests #821

AndyAyersMS opened this issue Sep 4, 2015 · 6 comments
Assignees
@richardlford

Comments

@AndyAyersMS
Copy link
Member

I asked a couple people and nobody could say for sure if we were skipping methods in the enabled tests. Seems like these days a 100% jit rate is a reasonable expectation.

So, we should make sure we're doing exactly this in our lab tests. @richardlford @russellhadley can one of you take this?
@richardlford richardlford self-assigned this Sep 4, 2015
@richardlford
Copy link
Contributor

@AndyAyersMS, I'll take this one.

@erozenfeld
Copy link
Member

We are skipping some methods:
Found 2490 results
2490 tests, 967092 methods, 966528 good, 564 bad (99% good)
[Tail call] 492
[ckFinite] 38
[Direct unmanaged call] 26
[unexpected type in load/store primitive] 8

@erozenfeld
Copy link
Member

I'll take tail call since I already implemented jmp and it should be similar.

@AndyAyersMS
Copy link
Member Author

Can you open issues for the others?

@erozenfeld
Copy link
Member

I opened new issues and updated the existing ones:
[Tail call] #191
[ckFinite] #846
[Direct unmanaged call] #499
[unexpected type in load/store primitive] #847

AndyAyersMS added a commit to AndyAyersMS/llilc that referenced this issue Sep 17, 2015
@AndyAyersMS
Exclude tests with varargs calling convention
712ce40 
This addresses dotnet#821 and dotnet#499.

Exclude tests with varargs callees under dotnet/coreclr#1440. Also improve the NYI message to call out varargs differently than native conventions.
@AndyAyersMS AndyAyersMS mentioned this issue Sep 17, 2015
Merged
@AndyAyersMS
Copy link
Member Author

@richardlford @russellhadley would be nice to get this done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richardlford richardlford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richardlford @AndyAyersMS @erozenfeld