Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-deprecated Azure Pipelines Ubuntu/Windows pool #339

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

akoeplinger
Copy link
Member

ubuntu-16.04 was removed recently (actions/runner-images#3287), bumping to 20.04

win2016 will be removed in March: actions/runner-images#4312, bumping to windows-2019

ubuntu-16.04 was removed recently (actions/runner-images#3287), bumping to 20.04

win2016 will be removed in March: actions/runner-images#4312, bumping to windows-2019
@akoeplinger
Copy link
Member Author

@echesakovMSFT it looks like the Linux build fails because there's a new RID and this doesn't work with the logic in

jitutils/bootstrap.sh

Lines 73 to 80 in 89c6aba

# Figure out which version to download. The "RID:" value from "dotnet --info" looks
# like this:
# RID: osx.10.12-x64
info=$(dotnet --info |grep RID:)
info=${info##*RID:* }
clangFormatUrl=https://clrjit.blob.core.windows.net/clang-tools/${info}/clang-format

We could either upload a ubuntu 20.04 version to the blob store or download the earlier version, what do you think?

@echesakov
Copy link
Contributor

I think for now we can fix the script by downloading an earlier version.
Actually, I didn't know that the clang-tools blobs use RIDs...

@akoeplinger
Copy link
Member Author

@echesakovMSFT done

Copy link
Contributor

@echesakov echesakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akoeplinger

@echesakov echesakov merged commit bf35492 into main Nov 2, 2021
@akoeplinger akoeplinger deleted the akoeplinger-patch-1 branch November 3, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants