Recognize curl as a downloading tool #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am11
force-pushed
the
feature/curl-support
branch
from
6f97ab3
to
2410350
Compare
am11
force-pushed
the
feature/curl-support
branch
from
2410350
to
e47b69e
Compare
|
cc @BruceForstall, PTAL. |
|
This LGTM. Can some @dotnet/jit-contrib Unix guru review? |
echesakov
reviewed
Oct 13, 2021
| status="${response[1]}" | ||
| fi | ||
|
|
||
| if (( status >= 200 || status < 400 )); then |
There was a problem hiding this comment.
What statuses other than 200 and 301 can indicate that the url is valid?
There was a problem hiding this comment.
2xx and 3xx classes indicate the success-like cases.
However, I just noticed that I am missing --location (or -L) below at curl invocations to indicate "follow redirect" in case of 301, 308 etc. (wget follows redirects by default, but curl requires -L).
am11
commented
Oct 13, 2021
am11
commented
Oct 13, 2021
|
@echesakovMSFT Any more feedback here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chances of having curl on a fresh Linux / macOS install are actually higher than having wget, but even if there is a tie, using available tool in PATH which does the job right is good. This is the only script related to runtime that force the user to install wget.
.. was about to run
brew install wgetthen thought I should do this first. 😄