Log the environment variables and failures that occur as part of DRIVEALL #325
Conversation
|
CC. @dotnet/jit-contrib, @BruceForstall |
|
I also logged #326, to track that we don't properly track assertions and so these 6 failures don't actually show: dotnet/runtime#51728. We actually exit early on the first failure, which doesn't seem desirable. |
| @@ -194,6 +194,11 @@ private static PrepAllResult Compute(PrepAllInfo pi) | |||
|
|
|||
| Console.WriteLine($"DRIVEALL: Invoking {driverName} {newCommandLine}"); | |||
|
|
|||
| foreach (var pair in pi.environment) | |||
| { | |||
| Console.WriteLine($" {pair.Key}={pair.Value}"); | |||
There was a problem hiding this comment.
Isn't this going to be pretty noisy?
There was a problem hiding this comment.
Its going to print around 12-15 lines per .log file. Compared to the diff file this isn't a lot, but it might be noisier than desired.
In your particular case above, are you running PMI asm diffs as part of jit-diff? There's some magic happening there that simply outputting the environment variables won't help identify, namely, it copies the base or diff JIT into the Core_Root directory.
Yes, this is jit-diff.bat diff --diff --pmi.
If there is a better/easier way to do that, I'd be all ears 😄. But as of now, printing the failing method number and these environment variables allows me to do something similar to:
$env:COMPlus_JitDisasm="*"
$env:COMPlus_JitDisasmAssemblies="System.Private.CoreLib"
$env:COMPlus_JitUnwindDump="*"
$env:COMPlus_JitEHDump="*"
$env:COMPlus_JitDiffableDasm=1
$env:COMPlus_ReadyToRun=0
$env:COMPlus_ZapDisable=1
$env:COMPlus_JitEnableNoWayAssert=1
$env:COMPlus_JitNoForceFallback=1
$env:COMPlus_JitRequired=1
$env:COMPlus_TieredCompilation=0
$env:COMPlus_JitStdOutFile="D:\Users\tagoo\Source\repos\runtime_base\artifacts\diffs\dasmset_5\diff\System.Private.CoreLib.dasm"
copy D:\Users\tagoo\Source\repos\runtime\artifacts\tests\coreclr\windows.x64.Debug\Tests\Core_Root\clrjit.dll D:\Users\tagoo\Source\repos\runtime\artifacts\tests\coreclr\windows.x64.Debug\Tests\Core_Root
devenv /debugexe D:\Users\tagoo\Source\repos\runtime\artifacts\tests\coreclr\windows.x64.Release\Tests\Core_Root\corerun.exe D:\Users\tagoo\Source\repos\jitutils\bin\pmi.dll PREPONE D:\Users\tagoo\Source\repos\runtime_base\artifacts\tests\coreclr\windows.x64.Release\Tests\Core_Root\System.Private.CoreLib.dll #####
(Setting AltJit to the debug clrjit.dll also works)
#326 is also slightly problematic as you have to debug to see certain asserts.
|
In your particular case above, are you running PMI asm diffs as part of jit-diff? There's some magic happening there that simply outputting the environment variables won't help identify, namely, it copies the base or diff JIT into the Core_Root directory. Shouldn't |
|
(btw, the succeeded/failed changes seem useful) |
…EALL (dotnet#325) * Log the environment variables that are set in DRIVEALL * Print the method and type # on failure
This simply logs the environment variables that are set as part of the invoked command and failures information to allow easier debugging and investigation into failures.
Before
After