[.JavaSource, .ApiXmlAdjuster] Use Nullable Reference Types #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `Java.Interop.Tools.JavaSource.dll` and `Xamarin.Android.Tools.ApiXmlAdjuster.dll` so that C# 8 [Nullable Reference Types][0] are used. [0]: https://docs.microsoft.com/dotnet/csharp/nullable-references
jpobst
approved these changes
Nov 5, 2020
Comment on lines
+57
to
+62
| public bool Abstract { get; set; } | ||
| public string? Deprecated { get; set; } | ||
| public bool Final { get; set; } | ||
| public string? Name { get; set; } | ||
| public bool Static { get; set; } | ||
| public string? Visibility { get; set; } |
There was a problem hiding this comment.
We shouldn't be indenting things like this. This isn't supported by code formatters such as .editorconfig and IDEs, so it causes a constant tooling fight for most people. (When I have the opportunity to reformat code I am generally doing the opposite and removing this indention. 😄 )
There was a problem hiding this comment.
But it's so much uglier and harder to easily read & scan without the extra whitespace. :-(
jonpryor
pushed a commit
that referenced
this pull request
Dec 17, 2020
…746) Update `Java.Interop.Localization.dll`, `Java.Interop.Tools.Cecil.dll`, `Java.Interop.Tools.Diagnostics.dll`, and `Java.Interop.Tools.Generator.dll` so that C# 8 [Nullable Reference Types][0] are used. [0]: https://docs.microsoft.com/dotnet/csharp/nullable-references
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Java.Interop.Tools.JavaSource.dllandXamarin.Android.Tools.ApiXmlAdjuster.dllso that C# 8Nullable Reference Types are used.