[main] Update dependencies from dotnet/sdk #16227

dotnet-maestro · 2023-04-25T04:01:57Z

This pull request updates the following dependencies

From https://github.com/dotnet/sdk

Subscription: f8ee08b0-6c3d-485a-6895-08db0a1df366
Build: 20230425.9
Date Produced: April 25, 2023 7:11:27 PM UTC
Commit: b82ba20
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.Common.ItemTemplates: from 8.0.100-preview.4.23224.16 to 8.0.100-preview.4.23225.9
- Microsoft.DotNet.MSBuildSdkResolver: from 8.0.100-preview.4.23224.16 to 8.0.100-preview.4.23225.9
- Microsoft.NET.Sdk: from 8.0.100-preview.4.23224.16 to 8.0.100-preview.4.23225.9
- Microsoft.TemplateEngine.Cli: from 8.0.100-preview.4.23224.16 to 8.0.100-preview.4.23225.9
- VS.Redist.Common.NetCore.SharedFramework.x64.8.0: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3
- Microsoft.NETCore.App.Ref: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3
- VS.Redist.Common.NetCore.TargetingPack.x64.8.0: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3
- Microsoft.NETCore.App.Host.win-x64: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3
- Microsoft.NETCore.DotNetHostResolver: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3
- Microsoft.NETCore.Platforms: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3
- Microsoft.AspNetCore.App.Ref: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3
- Microsoft.AspNetCore.App.Ref.Internal: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3
- Microsoft.AspNetCore.App.Runtime.win-x64: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3
- VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3
- dotnet-dev-certs: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3
- dotnet-user-jwts: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3
- dotnet-user-secrets: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3
- Microsoft.NET.ILLink.Tasks: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3
- Microsoft.Net.Compilers.Toolset: from 4.7.0-1.23222.1 to 4.7.0-1.23224.5
- Microsoft.Build: from 17.7.0-preview-23221-02 to 17.7.0-preview-23225-01
- Microsoft.NETCore.App.Runtime.win-x64: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- VS.Redist.Common.NetCore.SharedFramework.x64.8.0: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Ref: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.NetCore.TargetingPack.x64.8.0: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Host.win-x64: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.DotNetHostResolver: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.Platforms: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Ref: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Ref.Internal: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Runtime.win-x64: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- dotnet-dev-certs: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- dotnet-user-jwts: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- dotnet-user-secrets: from 8.0.0-preview.4.23224.5 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- Microsoft.NET.ILLink.Tasks: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)
- Microsoft.Net.Compilers.Toolset: from 4.7.0-1.23222.1 to 4.7.0-1.23224.5 (parent: Microsoft.NET.Sdk)
- Microsoft.Build: from 17.7.0-preview-23221-02 to 17.7.0-preview-23225-01 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Runtime.win-x64: from 8.0.0-preview.4.23224.7 to 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk)

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.16 -> To Version 8.0.100-preview.4.23224.17

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.17 -> To Version 8.0.100-preview.4.23224.21

Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.Net.Compilers.Toolset From Version 8.0.0-preview.4.23224.5 -> To Version 8.0.0-preview.4.23224.8 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.16 -> To Version 8.0.100-preview.4.23224.23 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23224.7 -> To Version 8.0.0-preview.4.23224.16 (parent: Microsoft.NET.Sdk

dotnet-maestro · 2023-04-25T07:30:03Z

Notification for subscribed users from https://github.com/dotnet/sdk:

@dotnet/domestic-cat

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/sdk) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

v-wuzhai · 2023-04-25T10:07:54Z

@dotnet/razor-compiler @dotnet/source-build-internal Could you take a look at the failures here?

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.16 -> To Version 8.0.100-preview.4.23225.2 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23224.7 -> To Version 8.0.0-preview.4.23224.17 (parent: Microsoft.NET.Sdk

jjonescz · 2023-04-25T10:39:07Z

@v-wuzhai I don't see errors in Razor compiler. There are some in aspnetcore, e.g. at https://github.com/dotnet/aspnetcore/blob/b3371bb30d2cafd171dee653893095f054eeae74/src/Mvc/Mvc.Razor/src/RazorPageBase.cs#L637 - seems like it's being built against the latest version of .NET runtime which has new overload of TextWriter.FlushAsync (added in dotnet/runtime#84325) so there are ambiguity warnings

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.16 -> To Version 8.0.100-preview.4.23225.3 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23224.7 -> To Version 8.0.0-preview.4.23224.17 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.16 -> To Version 8.0.100-preview.4.23225.4 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23224.7 -> To Version 8.0.0-preview.4.23224.17 (parent: Microsoft.NET.Sdk

lewing · 2023-04-25T16:36:41Z

cc @eerhardt @javiercn

lewing · 2023-04-25T17:00:45Z

dotnet/aspnetcore#47879 is where it shows up directly in aspnetcore

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.16 -> To Version 8.0.100-preview.4.23225.5 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23224.7 -> To Version 8.0.0-preview.4.23224.17 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.16 -> To Version 8.0.100-preview.4.23225.7 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23224.7 -> To Version 8.0.0-preview.4.23224.17 (parent: Microsoft.NET.Sdk

lewing · 2023-04-25T18:27:05Z

I've fixed the underlying issue in dotnet/aspnetcore#47879 but my team would very much like an installer build to test for p4 before the hours it will take for that change to make it here. @MichaelSimons what is the policy for patching sourcebuild?

MichaelSimons · 2023-04-25T18:34:50Z

@MichaelSimons what is the policy for patching sourcebuild?

You can create a patch for the fix in aspnetcore. Best to have a code owner signoff on the fix prior to creating the patch. Patch must have a Backport: PR/Issue comment in it - e.g. https://github.com/dotnet/installer/blob/main/src/SourceBuild/patches/command-line-api/0002-Use-net8.0-TFM-when-building-with-source-build.patch#L6.

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.16 -> To Version 8.0.100-preview.4.23225.8 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23224.7 -> To Version 8.0.0-preview.4.23224.17 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.16 -> To Version 8.0.100-preview.4.23225.9 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23224.7 -> To Version 8.0.0-preview.4.23225.3 (parent: Microsoft.NET.Sdk

src/SourceBuild/patches/aspnetcore/0002-Silence-Ambiguous-FlushAsync.patch

eerhardt · 2023-04-25T21:55:30Z

src/SourceBuild/patches/aspnetcore/0002-Silence-Ambiguous-FlushAsync.patch

+#pragma warning disable CA2016
+                 await writer.FlushAsync().ConfigureAwait(false);
+#pragma warning restore CA2016


Note this isn't how it is getting fixed in dotnet/aspnetcore#47879. I'm not sure it matters or not.

it will be removed as soon as aspnetcore makes it here so it doesn't matter

…hAsync.patch Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

MichaelSimons · 2023-04-25T22:31:43Z

Merging ahead of green CI. Last commit was to update a bad commit.

dotnet-maestro bot added 4 commits April 25, 2023 04:01

Update dependencies from https://github.com/dotnet/sdk build 20230424.17

a36beac

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.16 -> To Version 8.0.100-preview.4.23224.17

Update dependencies from https://github.com/dotnet/sdk build 20230424.21

825ff09

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23224.17 -> To Version 8.0.100-preview.4.23224.21

dotnet-maestro bot added 2 commits April 25, 2023 11:26

dotnet-maestro bot added 2 commits April 25, 2023 17:13

dotnet-maestro bot and others added 3 commits April 25, 2023 18:56

Silence compiler warnings in sourcebuild

6552aa2

lewing requested a review from a team as a code owner April 25, 2023 21:07

Merge branch 'main' into darc-main-feca2a9e-354d-4091-b624-4a99385a5167

649cc5c

eerhardt reviewed Apr 25, 2023

View reviewed changes

lewing approved these changes Apr 25, 2023

View reviewed changes

Update src/SourceBuild/patches/aspnetcore/0002-Silence-Ambiguous-Flus…

9f39b52

…hAsync.patch Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

MichaelSimons merged commit 0007377 into main Apr 25, 2023

MichaelSimons deleted the darc-main-feca2a9e-354d-4091-b624-4a99385a5167 branch April 25, 2023 22:31

build-analysis bot mentioned this pull request Apr 25, 2023

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/sdk #16227

[main] Update dependencies from dotnet/sdk #16227

dotnet-maestro bot commented Apr 25, 2023 •

edited

Loading

dotnet-maestro bot commented Apr 25, 2023

v-wuzhai commented Apr 25, 2023

jjonescz commented Apr 25, 2023

lewing commented Apr 25, 2023 •

edited

Loading

lewing commented Apr 25, 2023

lewing commented Apr 25, 2023 •

edited

Loading

MichaelSimons commented Apr 25, 2023

eerhardt Apr 25, 2023

lewing Apr 25, 2023

MichaelSimons commented Apr 25, 2023

[main] Update dependencies from dotnet/sdk #16227

[main] Update dependencies from dotnet/sdk #16227

Conversation

dotnet-maestro bot commented Apr 25, 2023 • edited Loading

From https://github.com/dotnet/sdk

Coherency Updates

dotnet-maestro bot commented Apr 25, 2023

Notification for subscribed users from https://github.com/dotnet/sdk:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

v-wuzhai commented Apr 25, 2023

jjonescz commented Apr 25, 2023

lewing commented Apr 25, 2023 • edited Loading

lewing commented Apr 25, 2023

lewing commented Apr 25, 2023 • edited Loading

MichaelSimons commented Apr 25, 2023

eerhardt Apr 25, 2023

Choose a reason for hiding this comment

lewing Apr 25, 2023

Choose a reason for hiding this comment

MichaelSimons commented Apr 25, 2023

dotnet-maestro bot commented Apr 25, 2023 •

edited

Loading

lewing commented Apr 25, 2023 •

edited

Loading

lewing commented Apr 25, 2023 •

edited

Loading