IL Verifiication in the new testing framework #9999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vzarytovskii
commented
Aug 25, 2020
•
vzarytovskii
commented
- Added some helper functions to the Compiler.fs for IL verification.
- Upgraded to the latest ILAsm/ILDasm, latest versions do not depend on the libcoreclr, and have proper binaries for all platforms.
- Running ILAsm/ILDasm on Linux/macOS as well as windows.
- Migrated couple of tests as an example.
cartermp
reviewed
Aug 25, 2020
| |> compile | ||
| |> shouldSucceed | ||
| |> verifyIL [""" | ||
| .field public static literal int32 x = int32(0x00000007) |
There was a problem hiding this comment.
For small things like this it's probably fine, but for the larger IL verification tests we'll likely want to keep the baseline files and load them during test running. Could we add an example of that?
There was a problem hiding this comment.
It's not supported yet, here's the issue: #10000
I plan to have it working by tomorrow, as a separate PR
cartermp
approved these changes
Aug 25, 2020
TIHan
approved these changes
Aug 25, 2020
vzarytovskii
added
Area-Testing Infrastructure
and removed
Area-Infrastructure
Area-Testing
labels
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Added IL verification to new framework; Make IL verification work on linux/mac * Do not dispose process, to successfully capture stderr, add timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.