use ImplicitZero instead of Return unit #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps here: tests\fsharp\core\comprehensions\test.fsx ? |
mexx
force-pushed
the
zero-for-return-unit
branch
from
163838d
to
130c86b
Compare
|
I've added the tests. Comments welcome. |
|
|
||
| module SideEffectListTests = | ||
| #if Portable | ||
| let printfn s = printfn "%s" s |
There was a problem hiding this comment.
I know you copy/paste from near tests (good), but maybe this is good opportunity to cleanup this duplication, adding the printfn function at top level
There was a problem hiding this comment.
@enricosada maybe, or better to get rid of the root cause. I mean why isn't it simply working for Portable too?
|
I've marked the language suggestion as approved https://fslang.uservoice.com/forums/245727-f-language/suggestions/10999326-interpret-do-action-as-let-action-in-zer |
|
Thanks for the contribution @mexx !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: fsprojects/FSharp.Control.AsyncSeq#38
UserVoice
This PR don't have any new test, any guidance where to find the tests for CEs and to put new for the change is welcome.