Enable Roslyn's non blocking code complete #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Microsoft.CodeAnalysis.xxx packages to version 2.0.0-rc3-61225-01
dsyme
reviewed
Dec 27, 2016
| @@ -305,6 +318,13 @@ type internal FSharpLanguageService(package : FSharpPackage) as this = | |||
| workspace.Options <- workspace.Options.WithChangedOption(NavigationBarOptions.ShowNavigationBar, FSharpCommonConstants.FSharpLanguageName, true) | |||
| let textViewAdapter = this.Package.ComponentModel.GetService<IVsEditorAdaptersFactoryService>() | |||
|
|
|||
| let blockForCompletionOption = | |||
| PerLanguageOption<bool>( | |||
| "CompletionOptions", "BlockForCompletionItems", defaultValue = true, | |||
There was a problem hiding this comment.
Do we really want to use "true" here as the default?
There was a problem hiding this comment.
No idea. As we pass false later, I don't think it matters.
|
@dotnet-bot test this please |
|
It turns out VS RC2 does not compatible with Roslyn nuget packages RC3-xxx. I'll revert updating. |
vasily-kirichenko
force-pushed
the
non-blocking-completion
branch
from
486ebee
to
a9d84bd
Compare
KevinRansom
approved these changes
Dec 29, 2016
|
Thank you for this and everything else you have done for the F# IDE. we appreciate it. Kevin |
|
Tagging @brettfo. Sounds like we'll need to create an rc3 release branch where we can update to these, or else I expect Find References will be broken for F# in RC3. |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* enable Roslyn's non blocking code complete update Microsoft.CodeAnalysis.xxx packages to version 2.0.0-rc3-61225-01 * roll back to Microsoft.CodyAnalysis.xxx RC2 nuget packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and update
Microsoft.CodeAnalysis.xxxpackages to version2.0.0-rc3-61225-01See #1825 (comment)
I cannot test it on VisualFSharp.sln due to #2098.