Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"System.Func overload-is-better": checking if anything breaks, or not (in which case, we'd like a test) #11538

Closed
wants to merge 10 commits into from
Closed

"System.Func overload-is-better": checking if anything breaks, or not (in which case, we'd like a test) #11538

wants to merge 10 commits into from

Commits on May 8, 2021

  1. checking if anything breaks, or not (in which case, we'd like a test)

    @smoothdeveloper
    smoothdeveloper committed May 8, 2021
    Configuration menu
    Copy the full SHA
    8343554 View commit details
    Browse the repository at this point in the history

  2. let compiling Query.fs from FSharp.Core pass, with hope to get tests … 

    …running (well, at least compile...).
    @smoothdeveloper
    smoothdeveloper committed May 8, 2021
    Configuration menu
    Copy the full SHA
    f2b6f3f View commit details
    Browse the repository at this point in the history

Commits on May 9, 2021

  1. add a test which should currently fail

    @smoothdeveloper
    smoothdeveloper committed May 9, 2021
    Configuration menu
    Copy the full SHA
    5d4a260 View commit details
    Browse the repository at this point in the history

  2. test failed as expected, now check if removing the special casing cau… 

    …ses any failure.
    @smoothdeveloper
    smoothdeveloper committed May 9, 2021
    Configuration menu
    Copy the full SHA
    a657c2d View commit details
    Browse the repository at this point in the history

  3. move to a warning message.

    @smoothdeveloper
    smoothdeveloper committed May 9, 2021
    Configuration menu
    Copy the full SHA
    a292e4e View commit details
    Browse the repository at this point in the history

  4. adjust field name mismatch with .fsi

    @smoothdeveloper
    smoothdeveloper committed May 9, 2021
    Configuration menu
    Copy the full SHA
    97389d3 View commit details
    Browse the repository at this point in the history

  5. define CalledMethod.GetCallerArgAt index: int (hoping this is correct… 

    … way)
    @smoothdeveloper
    smoothdeveloper committed May 9, 2021
    Configuration menu
    Copy the full SHA
    c3bc6ed View commit details
    Browse the repository at this point in the history

  6. Adjust ConstraintSolver.ResolveOverloading to check if the caller arg… 

    … is a lambda literal.

In such case, when we hit the func-is-better, we display a warning.
    @smoothdeveloper
    smoothdeveloper committed May 9, 2021
    Configuration menu
    Copy the full SHA
    31f8201 View commit details
    Browse the repository at this point in the history

  7. more tests

    @smoothdeveloper
    smoothdeveloper committed May 9, 2021
    Configuration menu
    Copy the full SHA
    bf87fed View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Merge branch 'main' into func-is-better-may-break-in-the-future

    @KevinRansom
    KevinRansom authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    3a0a59e View commit details
    Browse the repository at this point in the history