Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support metrics in ResourceMonitoring for Windows #5290

Merged
merged 10 commits into from
Jul 22, 2024
Merged

Support metrics in ResourceMonitoring for Windows #5290

merged 10 commits into from
Jul 22, 2024
+698 −245

Conversation

evgenyfedorov2
Copy link
Contributor

@evgenyfedorov2 evgenyfedorov2 commented Jul 15, 2024 •
edited by dotnet-policy-service bot
Loading

Fixes #4477

Microsoft Reviewers: Open in CodeFlow

@evgenyfedorov2 evgenyfedorov2 marked this pull request as ready for review July 15, 2024 17:20
@evgenyfedorov2 evgenyfedorov2 enabled auto-merge (squash) July 15, 2024 17:22
RussKie
RussKie reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interop needs more work.
These may be useful:

src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Windows/Interop/MemoryInfo.cs Outdated Show resolved Hide resolved
...ies/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Windows/Interop/MemoryInfo.Native.cs Outdated Show resolved Hide resolved
@evgenyfedorov2 evgenyfedorov2 merged commit c016405 into dotnet:main Jul 22, 2024
6 checks passed
@evgenyfedorov2 evgenyfedorov2 deleted the evgenyfedorov2/metrics_for_rm_windows branch July 23, 2024 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mobratil mobratil mobratil approved these changes

@geeknoid geeknoid Awaiting requested review from geeknoid

@RussKie RussKie Awaiting requested review from RussKie

Assignees

@evgenyfedorov2 evgenyfedorov2

Labels
area-fundamentals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support metrics in ResourceMonitoring for Windows
3 participants
@evgenyfedorov2 @RussKie @mobratil