-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Compaction logging #510
Conversation
@@ -553,7 +553,7 @@ public void AddAndReplaceEntries_AreThreadSafe() | |||
var entrySize = random.Next(0, 5); | |||
cache.Set(random.Next(0, 10), entrySize, new MemoryCacheEntryOptions { Size = entrySize }); | |||
} | |||
}, cts.Token); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to pass the token since we check via cts.IsCancellationRequested inside the tasks. Alternatively we can catch the TaskCancelledException from WaitAll
src/Caching/Memory/src/Microsoft.Extensions.Caching.Memory.csproj
Outdated
Show resolved
Hide resolved
Just out of curiosity: Why is the memory cache injecting a |
…master [automated] Merge branch 'release/2.2' => 'master'
* Add logging for compaction test * Fix AddAndReplaceEntries_AreThreadSafe Commit migrated from dotnet/extensions@c3c9c55
* Add logging for compaction test * Fix AddAndReplaceEntries_AreThreadSafe Commit migrated from dotnet/extensions@c3c9c55
* Add logging for compaction test * Fix AddAndReplaceEntries_AreThreadSafe Commit migrated from dotnet/extensions@c3c9c55
* Add logging for compaction test * Fix AddAndReplaceEntries_AreThreadSafe \n\nCommit migrated from dotnet/extensions@c3c9c55
Reopening aspnet/Caching#441 in the right repo.
Adding logging to test out my theory on aspnet/Caching#429.
Also fixing a test for https://github.com/aspnet/AspNetCore-Internal/issues/1374.