Upgrade Polly to version 8.3.0 (#4922)

dotnet · Feb 5, 2024 · 80abb8d · 80abb8d
1 parent 31f4d22
commit 80abb8d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/eng/packages/General.props b/eng/packages/General.props
@@ -37,10 +37,10 @@
     <PackageVersion Include="Microsoft.Extensions.Primitives" Version="$(MicrosoftExtensionsPrimitivesVersion)" />
     <PackageVersion Include="Microsoft.IO.RecyclableMemoryStream" Version="2.3.2" />
     <PackageVersion Include="Newtonsoft.Json" Version="13.0.1" />
-    <PackageVersion Include="Polly" Version="8.2.1" />
-    <PackageVersion Include="Polly.Core" Version="8.2.1" />
-    <PackageVersion Include="Polly.Extensions" Version="8.2.1" />
-    <PackageVersion Include="Polly.RateLimiting" Version="8.2.1" />
+    <PackageVersion Include="Polly" Version="8.3.0" />
+    <PackageVersion Include="Polly.Core" Version="8.3.0" />
+    <PackageVersion Include="Polly.Extensions" Version="8.3.0" />
+    <PackageVersion Include="Polly.RateLimiting" Version="8.3.0" />
     <PackageVersion Include="System.Buffers" Version="4.5.1" />
     <PackageVersion Include="System.Collections.Immutable" Version="$(SystemCollectionsImmutableVersion)" />
     <PackageVersion Include="System.CommandLine.NamingConventionBinder" Version="2.0.0-beta4.22272.1" />

diff --git a/eng/packages/TestOnly.props b/eng/packages/TestOnly.props
@@ -8,7 +8,7 @@
     <PackageVersion Include="Microsoft.Diagnostics.Tracing.TraceEvent" Version="3.1.3" />
     <PackageVersion Include="Moq.AutoMock" Version="3.1.0" />
     <PackageVersion Include="Moq" Version="4.18.4" />
-    <PackageVersion Include="Polly.Testing" Version="8.2.1" />
+    <PackageVersion Include="Polly.Testing" Version="8.3.0" />
     <PackageVersion Include="StrongNamer" Version="0.2.5" />
     <PackageVersion Include="System.Configuration.ConfigurationManager" Version="$(SystemConfigurationConfigurationManagerVersion)" />
     <PackageVersion Include="Xunit.Combinatorial" Version="1.5.25" />

diff --git a/...xtensions.Http.Resilience.Tests/Resilience/HttpClientBuilderExtensionsTests.Resilience.cs b/...xtensions.Http.Resilience.Tests/Resilience/HttpClientBuilderExtensionsTests.Resilience.cs
@@ -92,7 +92,13 @@ public void AddResilienceHandler_EnsureServicesNotAddedTwice()
         // add twice intentionally
         builder.AddResilienceHandler("test", ConfigureBuilder);
 
-        builder.Services.Should().HaveCount(count + 2);
+        // We check that the count of existing services is not unnecessary increased.
+        //
+        // The additional 3 services that are registered are related to:
+        // - Configuration of HTTP client options
+        // - Configuration of resilience pipeline
+        // - Registration of keyed service for resilience pipeline
+        builder.Services.Should().HaveCount(count + 3);
     }
 
     [Fact]