RevEng: Pass in correct arguments to ScaffoldingTypeMapper #9094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
scaffoldingTypeMapper
branch
from
c26c940 to
6d3a4ab
Compare
lajones
reviewed
Jul 6, 2017
| @@ -67,7 +67,7 @@ public ScaffoldingTypeMapper([NotNull] IRelationalTypeMapper typeMapper) | |||
| scaffoldUnicode = unicodeMapping.IsUnicode != stringMapping.IsUnicode ? (bool?)stringMapping.IsUnicode : null; | |||
|
|
|||
| // Check for size | |||
| var sizedMapping = TypeMapper.StringMapper.FindMapping(unicode: mapping.IsUnicode, keyOrIndex: keyOrIndex, maxLength: null); | |||
| var sizedMapping = TypeMapper.StringMapper.FindMapping(mapping.IsUnicode, keyOrIndex, maxLength: null); | |||
| scaffoldMaxLengh = sizedMapping.Size != stringMapping.Size ? stringMapping.Size : null; | |||
There was a problem hiding this comment.
Since you're in the file maybe fix the typo at line 71: scaffoldMaxLength is missing the t.
lajones
approved these changes
Jul 6, 2017
smitpatel
force-pushed
the
scaffoldingTypeMapper
branch
from
6d3a4ab to
61f1654
Compare
- Infer keyOrIndex & rowversion for DatabaseColumn - Flow ConcurrencyToken annotation from database model to generate ConcurrencyToken() - Generate IsRowVersion() for rowversion columns on SqlServer - Do not put name annotations for index/FK with default name - Add empty line at the end of DbContext to make it consistent with other generated code - Normalize timestamp/rowversion to rowversion on SqlServer
smitpatel
force-pushed
the
scaffoldingTypeMapper
branch
from
61f1654 to
2de6639
Compare
bricelam
reviewed
Jul 7, 2017
| @@ -233,8 +233,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder) | |||
|
|
|||
| entity.Property(e => e.TimestampColumn) | |||
| .HasColumnName("timestampColumn") | |||
| .HasColumnType("timestamp") | |||
| .ValueGeneratedOnAddOrUpdate(); | |||
| .IsRowVersion(); | |||
| @@ -99,7 +99,7 @@ public partial class AllDataTypes | |||
| public byte[] Varbinary123Column { get; set; } | |||
| [Column("varbinaryMaxColumn")] | |||
| public byte[] VarbinaryMaxColumn { get; set; } | |||
| [Column("timestampColumn", TypeName = "timestamp")] | |||
| [Column("timestampColumn")] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8697