Configure logging internally to not filter out Debug messages #9080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems AppVeyor fails on one of the new tests. |
ajcvickers
changed the title
|
@divega Super weird. It passed on both my machines, but not on AppVeyer. I made the change that I thought we needed to make in the first place and now it is passing on my machines and on AppVeyer. |
smitpatel
approved these changes
Jul 6, 2017
It turns out that this still works if and only if the app is not using AddDbContext/UseLoggerFactory. However, if the app is using AddDbContext/UseLoggerFactory and logging is correctly figured in the service provider from which these things come to not filter Debug messages, then this works too. So it's all super weird and hard to understand, but I think we already have the behavior we talked about this morning. Also, refactored DbContextTest into three files since it was getting too big for R#. Since the diff may be hard to read, the three tests added were: * Can_log_debug_events_with_OnConfiguring * Cannot_log_debug_events_with_default_UseLoggerFactory * Can_log_debug_events_with_UseLoggerFactory_when_configured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #9083
Added default configuration when we add logging to our service provider. Doesn't get used when the ILoggerFactory comes in from the outside.
Also, refactored DbContextTest into three files since it was getting too big for R#. Since the diff may be hard to read, the three tests added were: