Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IListSource on LocalView and EntityQueryable to further direct data binding #9003

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

ajcvickers
Copy link
Contributor

Issues #8898 #8899

Copy link
Contributor

@divega divega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you have a chance to check if WPF databinding also calls IListSource.GetList()?

@ajcvickers
Copy link
Contributor Author

No, would it change the decision to do this depending on the answer?

@divega
Copy link
Contributor

divega commented Jun 28, 2017

No, would it change the decision to do this depending on the answer?

No, I think this PR is fine regardless.

What I am still concerned about is the decision to deviate from what we had in EF6. I.e. .Local used to returned an ordered collection that could be used directly for WPF-like databinding but now you need another call to ToObservableCollection() which won't be discoverable unless in binding to these objects directly causes the exception.

@divega
Copy link
Contributor

divega commented Jun 28, 2017

That is why #8898 says

... but we also need to verify that doing so will help for WPF.

@ajcvickers
Copy link
Contributor Author

I'll leave #8898 open after merging this and we can bring it back to triage to discuss the priority of doing this investigation.

@ajcvickers ajcvickers force-pushed the KetchupBbqAndListSauce0628 branch from f1a9378 to 6bfb10c Compare June 28, 2017 23:47
@ajcvickers ajcvickers merged commit 6bfb10c into dev Jun 28, 2017
@smitpatel smitpatel deleted the KetchupBbqAndListSauce0628 branch July 5, 2017 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants