Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase max retry count default value to 6 so that we cover 1 full minute #8325

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Increase max retry count default value to 6 so that we cover 1 full minute #8325

merged 1 commit into from
Apr 28, 2017

Conversation

smitpatel
Copy link
Contributor

Resolves #8275

@smitpatel smitpatel requested a review from AndriySvyryd April 28, 2017 19:56
AndriySvyryd
AndriySvyryd approved these changes Apr 28, 2017
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the doc comment on SqlServerRetryingExecutionStrategy
Otherwise :shipit:

@smitpatel
Copy link
Contributor Author

smitpatel commented Apr 28, 2017 •
edited
Loading

What is the total time spent now?
the total amount of time spent before failing is 26 seconds plus the random factor.

@AndriySvyryd
Copy link
Member

56s + up to 5.6s of random delay, but you can say it's about a minute :)

@smitpatel smitpatel force-pushed the increasemaxretrycount branch 3 times, most recently from 632d321 to 4ed67eb Compare April 28, 2017 20:40
@smitpatel smitpatel force-pushed the increasemaxretrycount branch from 4ed67eb to 468843e Compare April 28, 2017 21:17
@smitpatel smitpatel merged commit 468843e into dev Apr 28, 2017
@smitpatel smitpatel deleted the increasemaxretrycount branch April 28, 2017 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smitpatel @AndriySvyryd @dnfclas