[release/9.0-staging] Make SnapshotModelProcessor idempotent. #35543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35146
Port of #35432
Description
Each EF migration contains a snapshot of the model at the time the migration was created. The snapshots might have been created by an older version of EF, so we need to run them through
SnapshotModelProcessorto make them conform to the current version of EF.Customer impact
In EF9 we changed the way model snapshots are handled to avoid initializing them again. However, when several certain migrations management operations are called in succession this could lead to the snapshots to be processed several times, which will result in an exception most of the times. The workaround is to avoid calling the operations in the same process, but this is not always possible.
How found
Multiple customer reports on 9.0.0
Regression
Yes, from 8.0.
Testing
Test added.
Risk
Low, this only affects design-time code.