[release/7.0] Fix to #31448 Use token for NonQueryResultAsync (#31449) #32334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#31449) Fixes dotnet#31448 (cherry picked from commit d2f824a)
AndriySvyryd
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31448, backports #31449
Description
The user-provided cancellation token was not being flown down for ExecuteUpdate/Delete operations.
Customer impact
When using ExecuteUpdate/Delete, triggering the cancellation token wouldn't affect the operation at all. This means that the program could hang indefinitely, e.g. in case of a network partition.
How found
Found by a customer.
Regression
No.
Testing
None.
Risk
Extremely low, just flows the cancellation token through.