Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies from dotnet/runtime. #27673

Closed
wants to merge 1 commit into from

Conversation

AraHaan
Copy link
Member

@AraHaan AraHaan commented Mar 21, 2022

I needed updated dependencies that remove DiagnosticSource from Extensions.Logging.

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team This is a trivial dependency update that does not change code.
  • The code builds and tests pass locally (also verified by our automated build checks) It should work with this manual dependency update.
  • Commit messages follow this format: (manual dependency update)
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features) (manual dependency update)
  • Code follows the same patterns and style as existing code in this repo (manual dependency update)

I needed updated dependencies that remove DiagnosticSource from Extensions.Logging.
@AraHaan AraHaan requested a review from dougbu as a code owner March 21, 2022 09:50
</Dependency>
<Dependency Name="System.Collections.Immutable" Version="7.0.0-preview.3.22163.2">
<Dependency Name="System.Collections.Immutable" Version="7.0.0-preview.3.22169.7">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to create a followup PR sometime to remove System.Collections.Immutable and System.Diagnostics.DiagnosticSource from efcore as well for the framework's copy of it.

@roji
Copy link
Member

roji commented Mar 21, 2022

@AraHaan we generally don't update dependencies manually in this way. Can you provide more context on removing System.Diagnostics.DiagnosticSource and System.Collections.Immutable?

@AraHaan
Copy link
Member Author

AraHaan commented Mar 21, 2022

Sure, basically in my codebase from it's package dependencies (from efcore and it's dependencies) copy a lot of assemblies which are either: 1. old packages (to those in the runtime/ref packs and probably outdated) or 2. packages to what is in the runtime & ref packs. As such I been annoyed at removing those assemblies manually to prefer those from the runtime packs (since it is FDD and not SCD). As such I expect to have them in my application output directory only when SCD and not when FDD so that way no matter what it will load the newest version from the runtime installed (ex if 6.0.0 is installed but it sees 7.0.0 it will use 7.0.0's copy of these).

Also I do not know of any changes to Immutable or even DiagnosticSource since the 6.0.0 release, so I think we should be fine with removing the package references for the runtime pack copy of them both. I been also working on doing the same to SqlClient as well (which also requires updates to the Azure deps from SqlClient).

After those are successfully done it will eliminate a lot of needless assembly copies on my build outputs which happen to exist in the Microsoft.NETCore.App framework (when targeting .NET 6+).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants